Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: src/compiler/mips/code-generator-mips.cc

Issue 1211143003: MIPS: Fix '[turbofan] Add CalleeSavedFPRegisters to CallDescriptor.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/mips64/code-generator-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/mips/code-generator-mips.cc
diff --git a/src/compiler/mips/code-generator-mips.cc b/src/compiler/mips/code-generator-mips.cc
index 8bb47ef4f79e3fcc0196dd23e10b9d57f0df1850..a7806ccae236c2ee0e83399386915b1480f9d299 100644
--- a/src/compiler/mips/code-generator-mips.cc
+++ b/src/compiler/mips/code-generator-mips.cc
@@ -1082,7 +1082,9 @@ void CodeGenerator::AssemblePrologue() {
const RegList saves = descriptor->CalleeSavedRegisters();
// Save callee-saved registers.
__ MultiPush(saves);
- DCHECK(kNumCalleeSaved == base::bits::CountPopulation32(saves));
+ // kNumCalleeSaved includes the fp register, but the fp register
+ // is saved separately in TF.
+ DCHECK(kNumCalleeSaved == base::bits::CountPopulation32(saves) + 1);
int register_save_area_size = kNumCalleeSaved * kPointerSize;
const RegList saves_fpu = descriptor->CalleeSavedFPRegisters();
« no previous file with comments | « no previous file | src/compiler/mips64/code-generator-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698