Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1211143003: MIPS: Fix '[turbofan] Add CalleeSavedFPRegisters to CallDescriptor.' (Closed)

Created:
5 years, 5 months ago by akos.palfi.imgtec
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix '[turbofan] Add CalleeSavedFPRegisters to CallDescriptor.' Fixes debug mode assertions. TEST=cctest/test-run-machops/RunChangeUint32ToFloat64_B BUG= Committed: https://crrev.com/1ab39b49431207232a6217b078b9b02751c60fb6 Cr-Commit-Position: refs/heads/master@{#29420}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
akos.palfi.imgtec
PTAL.
5 years, 5 months ago (2015-07-01 13:14:17 UTC) #2
balazs.kilvady
LGTM
5 years, 5 months ago (2015-07-01 13:17:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211143003/1
5 years, 5 months ago (2015-07-01 13:17:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 14:20:01 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 14:20:22 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1ab39b49431207232a6217b078b9b02751c60fb6
Cr-Commit-Position: refs/heads/master@{#29420}

Powered by Google App Engine
This is Rietveld 408576698