Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: Source/bindings/v8/ExceptionState.cpp

Issue 121113004: Improve handling of failed integer type conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionState.cpp
diff --git a/Source/bindings/v8/ExceptionState.cpp b/Source/bindings/v8/ExceptionState.cpp
index 77c9103d7be7afe21926f028d6d315689b8af907..37deb8271e68fb117f3141b275d1d729b326f2c2 100644
--- a/Source/bindings/v8/ExceptionState.cpp
+++ b/Source/bindings/v8/ExceptionState.cpp
@@ -83,6 +83,24 @@ void ExceptionState::throwTypeError(const String& message)
setException(V8ThrowException::createTypeError(addExceptionContext(message), m_isolate));
}
+void NonThrowableExceptionState::throwDOMException(const ExceptionCode& ec, const String& message)
+{
+ ASSERT_NOT_REACHED();
+ m_code = ec;
+}
+
+void NonThrowableExceptionState::throwTypeError(const String&)
+{
+ ASSERT_NOT_REACHED();
+ m_code = TypeError;
+}
+
+void NonThrowableExceptionState::throwSecurityError(const String&, const String&)
+{
+ ASSERT_NOT_REACHED();
+ m_code = SecurityError;
+}
+
void TrackExceptionState::throwDOMException(const ExceptionCode& ec, const String& message)
{
m_code = ec;
« no previous file with comments | « Source/bindings/v8/ExceptionState.h ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698