Source/bindings/tests/results/V8TestInterface.cpp - Issue 121113004: Improve handling of failed integer type conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 121113004: Improve handling of failed integer type conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestEventTarget.cpp ('k') | Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp

index 80714c83540270612720822644a93e1e21c9d0da..18cd8db649a642230d230afbb02113597f7156f2 100644

--- a/Source/bindings/tests/results/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/V8TestInterface.cpp

@@ -679,11 +679,12 @@ static void supplementalMethod4MethodCallback(const v8::FunctionCallbackInfo<v8:

static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info)

{

+ ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterface", info.Holder(), info.GetIsolate());

if (UNLIKELY(info.Length() < 1)) {

- throwTypeError(ExceptionMessages::failedToConstruct("TestInterface", ExceptionMessages::notEnoughArguments(1, info.Length())), info.GetIsolate());

+ exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(1, info.Length()));

+ exceptionState.throwIfNeeded();

return;

}

- ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterface", info.Holder(), info.GetIsolate());

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, str1, info[0]);

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, str2, info[1]);

ExecutionContext* context = getExecutionContext();