Source/bindings/scripts/unstable/v8_methods.py - Issue 121113004: Improve handling of failed integer type conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/v8_methods.py

Issue 121113004: Improve handling of failed integer type conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update new IDL compiler to match Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/code_generator_v8.pm ('K') | « Source/bindings/scripts/unstable/v8_attributes.py ('k') | Source/bindings/scripts/unstable/v8_types.py » ('j') | Source/bindings/scripts/unstable/v8_types.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/unstable/v8_methods.py

diff --git a/Source/bindings/scripts/unstable/v8_methods.py b/Source/bindings/scripts/unstable/v8_methods.py

index 82038ec10bc5b5512e95a7e093eb5f713d91b529..c5661689c930442027ed94bfafa5efc505f3f24a 100644

--- a/Source/bindings/scripts/unstable/v8_methods.py

+++ b/Source/bindings/scripts/unstable/v8_methods.py

@@ -80,9 +80,10 @@ def generate_method(interface, method):

includes.add('core/dom/custom/CustomElementCallbackDispatcher.h')

# Used for 'has_exception_state' (do we have an ExceptionState variable?)

- has_serialized_script_value_argument = any(

+ has_exception_raising_argument = any(

Nils Barth (inactive) 2014/01/06 02:58:09 Could you inline this into the value for 'has_ex

sof 2014/01/06 21:01:25 Done.

argument for argument in arguments

- if argument.idl_type == 'SerializedScriptValue')

+ if argument.idl_type == 'SerializedScriptValue' or

+ v8_types.is_integer_type(argument.idl_type))

is_check_security_for_frame = (

'CheckSecurity' in interface.extended_attributes and

'DoNotCheckSecurity' not in extended_attributes)

@@ -105,9 +106,8 @@ def generate_method(interface, method):

'idl_type': idl_type,

'has_exception_state':

is_raises_exception or is_check_security_for_frame or

- has_serialized_script_value_argument or

+ has_exception_raising_argument or

name in ['addEventListener', 'removeEventListener'],

- 'has_serialized_script_value_argument': has_serialized_script_value_argument,

'is_call_with_execution_context': has_extended_attribute_value(method, 'CallWith', 'ExecutionContext'),

'is_call_with_script_arguments': is_call_with_script_arguments,

'is_call_with_script_state': is_call_with_script_state,