Source/bindings/scripts/unstable/v8_types.py - Issue 121113004: Improve handling of failed integer type conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/v8_types.py

Issue 121113004: Improve handling of failed integer type conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update expected outputs Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/code_generator_v8.pm ('K') | « Source/bindings/scripts/code_generator_v8.pm ('k') | Source/bindings/tests/results/V8TestEventTarget.cpp » ('j') | Source/bindings/tests/results/V8TestObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/unstable/v8_types.py

diff --git a/Source/bindings/scripts/unstable/v8_types.py b/Source/bindings/scripts/unstable/v8_types.py

index 131b804ce9e7c792218028e3314687d19c046e8d..eb8fc2d94bd2636ffafd8b0dbd3662759848983c 100644

--- a/Source/bindings/scripts/unstable/v8_types.py

+++ b/Source/bindings/scripts/unstable/v8_types.py

@@ -377,7 +377,7 @@ def v8_value_to_cpp_value(idl_type, extended_attributes, v8_value, index):

add_includes_for_type(idl_type)

if 'EnforceRange' in extended_attributes:

- arguments = ', '.join([v8_value, 'EnforceRange', 'ok'])

+ arguments = ', '.join([v8_value, 'EnforceRange', 'exceptionState'])

else: # NormalConversion

arguments = v8_value

@@ -422,7 +422,7 @@ def v8_value_to_local_cpp_value(idl_type, extended_attributes, v8_value, variabl

if idl_type == 'DOMString':

format_string = 'V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID({cpp_type}, {variable_name}, {cpp_value})'

elif 'EnforceRange' in extended_attributes:

- format_string = 'V8TRYCATCH_WITH_TYPECHECK_VOID({cpp_type}, {variable_name}, {cpp_value}, info.GetIsolate())'

+ format_string = 'V8TRYCATCH_EXCEPTION_VOID({cpp_type}, {variable_name}, {cpp_value}, exceptionState)'

else:

format_string = 'V8TRYCATCH_VOID({cpp_type}, {variable_name}, {cpp_value})'