Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: LayoutTests/fast/dom/exception-in-binding.html

Issue 121113004: Improve handling of failed integer type conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update new IDL compiler to match Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/canvas/webgl/gl-object-get-calls-expected.txt ('k') | LayoutTests/fast/dom/exception-in-binding-expected.txt » ('j') | Source/bindings/scripts/code_generator_v8.pm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <meta charset="utf-8"> 4 <script src="../../resources/js-test.js"></script>
5 <script src="../../resources/js-test.js"></script> 5 <script>
6 <script> 6 description("Tests to ensure that attributes are not set when an exceptions is r aised while converting argument to JSValue.");
7 description("Tests to ensure that attributes are not set when an exceptions is raised while converting argument to JSValue."); 7 window.jsTestIsAsync = true;
8 function setName(select) { 8 function setName(select) {
9 var stringLike = { 9 var stringLike = {
10 toString: function() { 10 toString: function() {
11 throw new Error("error"); 11 throw new Error("error");
12 } 12 }
13 }; 13 };
14 select.name = stringLike;; 14 select.name = stringLike;
15 } 15 }
16 16
17 function setSelectedIndex(select) { 17 function setSelectedIndex(select) {
18 var integerLike = { 18 var integerLike = {
19 valueOf: function() { 19 valueOf: function() {
20 throw new Error("error"); 20 throw new Error("error");
21 } 21 }
22 }; 22 };
23 select.selectedIndex = integerLike;; 23 select.selectedIndex = integerLike;
24 } 24 }
25 25
26 function runTest() { 26 function runTest() {
27 var select = document.getElementById("select"); 27 shouldThrow('setName(select)');
28 try { 28 shouldBe('select.name', '"select"');
29 setName(select);
30 } catch(e) {
31 }
32 shouldBe('select.name', '"select"');
33 29
34 try { 30 shouldThrow('setSelectedIndex(select)');
35 setSelectedIndex(select); 31 shouldBe('select.selectedIndex', '1');
36 } catch(e) { 32 finishJSTest();
37 } 33 }
38 shouldBe('select.selectedIndex', '1'); 34 </script>
39 } 35 </head>
40 </script> 36 <body onload="runTest()">
41 37 <select id="select" name="select">
42 </head> 38 <option value="value1">Value 1</option>
43 <body onload="runTest()"> 39 <option value="value2" selected>Value 2</option>
44 <select id="select" name="select"> 40 <option value="value3">Value 3</option>
45 <option value="value1">Value 1</option> 41 </select>
46 <option value="value2" selected>Value 2</option>
47 <option value="value3">Value 3</option>
48 </select>
49 <p id="description"></p>
50 <script src="../../resources/js-test.js"></script>
51 </body> 42 </body>
52 </html> 43 </html>
OLDNEW
« no previous file with comments | « LayoutTests/fast/canvas/webgl/gl-object-get-calls-expected.txt ('k') | LayoutTests/fast/dom/exception-in-binding-expected.txt » ('j') | Source/bindings/scripts/code_generator_v8.pm » ('J')

Powered by Google App Engine
This is Rietveld 408576698