Issue 1211123004: Revert of Return GrGLContext from GrTestTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1211123004: Revert of Return GrGLContext from GrTestTarget (Closed)

Created:
5 years, 6 months ago by reed2

Modified:
5 years, 6 months ago

Reviewers:
joshualitt, bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Return GrGLContext from GrTestTarget (patchset #3 id:40001 of https://codereview.chromium.org/1207393002/) Reason for revert: speculative revert to unblock DEPS roll (layout-tests) Original issue's description: > Return GrGLContext from GrTestTarget > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/b6d93ea428ca5d13641c35faca7d0380980a3a17 TBR=bsalomon@google.com,joshualitt@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/1852ec2b46a2a0efbb3550ff4d8b640f56a810e9

Patch Set 1 #

Created: 5 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -19 lines)			Patch
M	gm/imagefromyuvtextures.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrTest.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrTest.cpp	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/gpu/gl/GrGLContext.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLGpu.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/ResourceCacheTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/SurfaceTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211123004/1

5 years, 6 months ago (2015-06-26 01:59:24 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1852ec2b46a2a0efbb3550ff4d8b640f56a810e9

5 years, 6 months ago (2015-06-26 01:59:37 UTC) #3

reed2

5 years, 6 months ago (2015-06-26 04:29:01 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1215593002/ by reed@chromium.org.

The reason for reverting is: un-referting, did not help DEPS roll.

Expand Messages | Collapse Messages