Issue 12111002: Add support for svn paths in the revert (removes need for .properties file).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12111002: Add support for svn paths in the revert (removes need for .properties file). (Closed)

Created:
7 years, 10 months ago by laforge

Modified:
7 years, 10 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

Add support for svn paths in the revert (removes need for .properties file). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179457

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -3 lines)			Patch
	M	drover.py	View	1	5 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

7 years, 10 months ago (2013-01-29 23:04:10 UTC) #2

lgtm with nit

https://codereview.chromium.org/12111002/diff/1/drover.py
File drover.py (right):

https://codereview.chromium.org/12111002/diff/1/drover.py#newcode198
drover.py:198: subpaths.pop(0)
Could you add a one line comment why it's done? I fail to deduce.

https://codereview.chromium.org/12111002/diff/1/drover.py#newcode570
drover.py:570: pop_em = (options.url == None or options.url == '')
pop_em = not options.url

Expand Messages | Collapse Messages