Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1211083006: Move TemplateURLService preferences registration to the component (Closed)

Created:
5 years, 5 months ago by sdefresne
Modified:
5 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TemplateURLService preferences registration to the component Move the preferences registration to a static method of TemplateURLService so that it can be shared by different embedders and call the method from the factory. BUG=371535 Committed: https://crrev.com/294879611d3d64e57d762a117413a2f14bed03ad Cr-Commit-Position: refs/heads/master@{#337297}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -36 lines) Patch
M chrome/browser/search_engines/template_url_service_factory.cc View 1 chunk +1 line, -36 lines 0 comments Download
M components/search_engines/template_url_service.h View 2 chunks +7 lines, -0 lines 0 comments Download
M components/search_engines/template_url_service.cc View 2 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sdefresne
Please take a look.
5 years, 5 months ago (2015-07-02 12:19:05 UTC) #2
Peter Kasting
LGTM
5 years, 5 months ago (2015-07-03 09:05:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211083006/1
5 years, 5 months ago (2015-07-03 09:20:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-03 09:24:46 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-03 09:26:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/294879611d3d64e57d762a117413a2f14bed03ad
Cr-Commit-Position: refs/heads/master@{#337297}

Powered by Google App Engine
This is Rietveld 408576698