Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 1211053005: Convert compositor_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
danakj, M-A Ruel
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert compositor_unittests to run exclusively on Swarming 0 configs already ran on Swarming 18 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert compositor_unittests BUG=98637 Committed: https://crrev.com/db1d33845c8847693ab97db88fbcff754c6b3a5b Cr-Commit-Position: refs/heads/master@{#337334} Committed: https://crrev.com/4e9a51bd130affb9ebfdfd8c57638e8dc0a99a3e Cr-Commit-Position: refs/heads/master@{#337543}

Patch Set 1 #

Patch Set 2 : works locally on mac #

Patch Set 3 : reformat #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : .. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -22 lines) Patch
M build/gn_migration.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 chunk +3 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download
M ui/compositor/compositor.gyp View 1 chunk +15 lines, -0 lines 0 comments Download
A + ui/compositor/compositor_unittests.isolate View 1 2 3 4 5 4 chunks +11 lines, -22 lines 3 comments Download

Messages

Total messages: 17 (3 generated)
Nico
danakj: ui/compositor maruel: testing/
5 years, 5 months ago (2015-07-03 00:39:50 UTC) #2
M-A Ruel
lgtm https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/compositor_unittests.isolate File ui/compositor/compositor_unittests.isolate (right): https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/compositor_unittests.isolate#newcode19 ui/compositor/compositor_unittests.isolate:19: ['(OS=="linux" or OS=="mac" or OS=="win") and use_x11==1', { ...
5 years, 5 months ago (2015-07-03 01:53:46 UTC) #3
Nico
https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/compositor_unittests.isolate File ui/compositor/compositor_unittests.isolate (right): https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/compositor_unittests.isolate#newcode19 ui/compositor/compositor_unittests.isolate:19: ['(OS=="linux" or OS=="mac" or OS=="win") and use_x11==1', { On ...
5 years, 5 months ago (2015-07-03 02:00:50 UTC) #4
tfarina
https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/compositor_unittests.isolate File ui/compositor/compositor_unittests.isolate (right): https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/compositor_unittests.isolate#newcode1 ui/compositor/compositor_unittests.isolate:1: # Copyright (c) 2015 The Chromium Authors. All rights ...
5 years, 5 months ago (2015-07-03 02:01:59 UTC) #5
danakj
lgtm
5 years, 5 months ago (2015-07-03 22:46:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211053005/100001
5 years, 5 months ago (2015-07-04 00:00:55 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 5 months ago (2015-07-04 01:13:16 UTC) #9
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/db1d33845c8847693ab97db88fbcff754c6b3a5b Cr-Commit-Position: refs/heads/master@{#337334}
5 years, 5 months ago (2015-07-04 01:14:21 UTC) #10
tapted
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/1214063007/ by tapted@chromium.org. ...
5 years, 5 months ago (2015-07-05 23:32:00 UTC) #11
Nico
On Sun, Jul 5, 2015 at 4:32 PM, <tapted@chromium.org> wrote: > A revert of this ...
5 years, 5 months ago (2015-07-05 23:33:13 UTC) #12
Nico
This might work now that https://codereview.chromium.org/1212463005/ is in. Relanding…
5 years, 5 months ago (2015-07-07 00:55:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211053005/100001
5 years, 5 months ago (2015-07-07 00:56:15 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 5 months ago (2015-07-07 01:58:03 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 01:59:05 UTC) #17
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4e9a51bd130affb9ebfdfd8c57638e8dc0a99a3e
Cr-Commit-Position: refs/heads/master@{#337543}

Powered by Google App Engine
This is Rietveld 408576698