Convert compositor_unittests to run exclusively on Swarming

Convert compositor_unittests to run exclusively on Swarming

0 configs already ran on Swarming
18 used to run locally and were converted:
- chromium.chromiumos.json: Linux ChromiumOS Tests (1)
- chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1)
- chromium.fyi.json: ClangToTLinux tester
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)
- chromium.linux.json: Linux Tests
- chromium.linux.json: Linux Tests (dbg)(1)
- chromium.linux.json: Linux Tests (dbg)(1)(32)
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.memory.json: Linux Chromium OS ASan LSan Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (1)
- chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1)
- chromium.win.json: Vista Tests (1)
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
- chromium.win.json: Win7 Tests (dbg)(1)
- chromium.win.json: XP Tests (1)

Ran:
  ./manage.py --convert compositor_unittests

BUG=98637
Committed: https://crrev.com/db1d33845c8847693ab97db88fbcff754c6b3a5b
Cr-Commit-Position: refs/heads/master@{#337334}

Committed: https://crrev.com/4e9a51bd130affb9ebfdfd8c57638e8dc0a99a3e
Cr-Commit-Position: refs/heads/master@{#337543}

[Nico, 2015-07-03 00:39:49]

thakis@chromium.org changed reviewers:
+ danakj@chromium.org, maruel@chromium.org

[Nico, 2015-07-03 00:39:50]

danakj: ui/compositor
maruel: testing/

[M-A Ruel, 2015-07-03 01:53:46]

lgtm

https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/composit...
File ui/compositor/compositor_unittests.isolate (right):

https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/composit...
ui/compositor/compositor_unittests.isolate:19: ['(OS=="linux" or OS=="mac" or
OS=="win") and use_x11==1', {
(OS=="linux" or OS=="mac" or OS=="win") is pointless in the sense that
use_x11==1 can only happen on linux, so we never test for the OS version there.

[Nico, 2015-07-03 02:00:50]

https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/composit...
File ui/compositor/compositor_unittests.isolate (right):

https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/composit...
ui/compositor/compositor_unittests.isolate:19: ['(OS=="linux" or OS=="mac" or
OS=="win") and use_x11==1', {
On 2015/07/03 01:53:45, M-A Ruel wrote:
> (OS=="linux" or OS=="mac" or OS=="win") is pointless in the sense that
> use_x11==1 can only happen on linux, so we never test for the OS version
there.

Yes, but I thought it looked more like the else to the previous block if the
condition is most similar. I'll change it if you want though.

[tfarina, 2015-07-03 02:01:59]

https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/composit...
File ui/compositor/compositor_unittests.isolate (right):

https://codereview.chromium.org/1211053005/diff/100001/ui/compositor/composit...
ui/compositor/compositor_unittests.isolate:1: # Copyright (c) 2015 The Chromium
Authors. All rights reserved.
no (c)?

[danakj, 2015-07-03 22:46:49]

lgtm

[Nico, 2015-07-03 23:47:36]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-07-04 00:00:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211053005/100001

[commit-bot: I haz the power, 2015-07-04 01:13:16]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-04 01:14:21]

Patchset 6 (id:??) landed as
https://crrev.com/db1d33845c8847693ab97db88fbcff754c6b3a5b
Cr-Commit-Position: refs/heads/master@{#337334}

[tapted, 2015-07-05 23:32:00]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1214063007/ by tapted@chromium.org.

The reason for reverting is: Causing steps exception compositor_unittests on
Linux ChromiumOS Tests (dbg)(1)
Link:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

Shard https://chromium-swarm.appspot.com/user/task/286f8616fee52710 says

Outputs:
Output:
Sending the crash report ... done.
Report URL:
https://isolateserver.appspot.com/restricted/ereporter2/errors/5669961011822592
IsolatedFile a8902feeee5e075f3f92ec6ae3299106595667a3 is retrieved recursively.

[Nico, 2015-07-05 23:33:13]

On Sun, Jul 5, 2015 at 4:32 PM, <tapted@chromium.org> wrote:

> A revert of this CL (patchset #6 id:100001) has been created in
> https://codereview.chromium.org/1214063007/ by tapted@chromium.org.
>
> The reason for reverting is: Causing steps exception compositor_unittests
> on
> Linux ChromiumOS Tests (dbg)(1)
> Link:
>
>
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...
>
> Shard https://chromium-swarm.appspot.com/user/task/286f8616fee52710 says
>
> Outputs:
> Output:
> Sending the crash report ... done.
> Report URL:
>
>
https://isolateserver.appspot.com/restricted/ereporter2/errors/5669961011822592
> IsolatedFile a8902feeee5e075f3f92ec6ae3299106595667a3 is retrieved
> recursively.
>

maruel, is there any way to make this output more useful? Debugging
swarming failures is super mysterious. The best thing I've found is to
build and run the isolate locally, and it happens to pass there :-/


>
> https://codereview.chromium.org/1211053005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-07-07 00:55:05]

This might work now that https://codereview.chromium.org/1212463005/ is in.
Relanding…

[Nico, 2015-07-07 00:55:48]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-07-07 00:56:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1211053005/100001

[commit-bot: I haz the power, 2015-07-07 01:58:03]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-07-07 01:59:05]

Patchset 6 (id:??) landed as
https://crrev.com/4e9a51bd130affb9ebfdfd8c57638e8dc0a99a3e
Cr-Commit-Position: refs/heads/master@{#337543}