Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1211023003: Fix recording of "Time to error histograms". (Closed)

Created:
5 years, 5 months ago by Randy Smith (Not in Mondays)
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org, Bryan McQuade
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix recording of "Time to error histograms". Changes use of URLRequest::request_time() to URLRequest::creation_time(), which is much closer to the information actually desired (how long the consumer of the request waited for an error). BUG=487663 R=mmenke@chromium.org Committed: https://crrev.com/1f43a06a1ebfdb2fdb16bd3356dd6baa7cf6b4a5 Cr-Commit-Position: refs/heads/master@{#337899}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Xref new histogram name from obsolete histogram. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Randy Smith (Not in Mondays)
Matt: Simple fix for time-to-error histograms. PTAL?
5 years, 5 months ago (2015-07-08 18:56:26 UTC) #1
mmenke
On 2015/07/08 18:56:26, rdsmith wrote: > Matt: Simple fix for time-to-error histograms. PTAL? LGTM, apologies ...
5 years, 5 months ago (2015-07-08 18:57:56 UTC) #2
Randy Smith (Not in Mondays)
On 2015/07/08 18:57:56, mmenke wrote: > On 2015/07/08 18:56:26, rdsmith wrote: > > Matt: Simple ...
5 years, 5 months ago (2015-07-08 19:10:36 UTC) #4
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1211023003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1211023003/diff/1/tools/metrics/histograms/histograms.xml#newcode22642 tools/metrics/histograms/histograms.xml:22642: + Revving version due to failure in original ...
5 years, 5 months ago (2015-07-08 19:16:23 UTC) #5
Randy Smith (Not in Mondays)
Thanks! https://codereview.chromium.org/1211023003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1211023003/diff/1/tools/metrics/histograms/histograms.xml#newcode22642 tools/metrics/histograms/histograms.xml:22642: + Revving version due to failure in original ...
5 years, 5 months ago (2015-07-08 19:20:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211023003/20001
5 years, 5 months ago (2015-07-08 19:21:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-08 20:34:30 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 20:35:22 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1f43a06a1ebfdb2fdb16bd3356dd6baa7cf6b4a5
Cr-Commit-Position: refs/heads/master@{#337899}

Powered by Google App Engine
This is Rietveld 408576698