Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1211023002: Revert of Support Compat mode inside of the desktop tree. (Closed)

Created:
5 years, 6 months ago by Mike Wittman
Modified:
5 years, 6 months ago
CC:
chromium-reviews, dtseng+watch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, aboxhall+watch_chromium.org, mazda+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, plundblad+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org, Greg Levin
Base URL:
https://chromium.googlesource.com/chromium/src.git@commands_alt
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support Compat mode inside of the desktop tree. (patchset #12 id:220001 of https://codereview.chromium.org/1191783002/) Reason for revert: Crashes tests on Linux ChromiumOS Tests (1): TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateSystemTray_0 TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateSystemTray_1 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/5005 Original issue's description: > Support Compat mode inside of the desktop tree. > > Depends on > https://codereview.chromium.org/1185753008/ > > Removes native bindings for Search+Shift+Arrows in favor of the extension commands bindings. Enables all ChromeVox Compat/Next commands inside of the desktop tree. Adds a test to exercise next element and next button commands. > > Also, whitelists root nodes without urls for ChromeVox compat. This includes the shelf/launcher. > > TEST=SpokenFeedbackTest.* > > Committed: https://crrev.com/e7b1c72c03dcf636e50917b2c8122e5d0ef884b6 > Cr-Commit-Position: refs/heads/master@{#336181} TBR=dmazzoni@chromium.org,oshima@chromium.org,dtseng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -94 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +40 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/accelerators/accelerator_table.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 9 chunks +21 lines, -33 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/classic_compatibility.js View 2 chunks +11 lines, -43 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/host.js View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mike Wittman
Created Revert of Support Compat mode inside of the desktop tree.
5 years, 6 months ago (2015-06-25 18:06:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1211023002/1
5 years, 6 months ago (2015-06-25 18:09:59 UTC) #2
commit-bot: I haz the power
Failed to apply the patch.
5 years, 6 months ago (2015-06-25 18:13:31 UTC) #4
Mike Wittman
5 years, 6 months ago (2015-06-25 18:17:39 UTC) #5
Message was sent while issue was closed.
Closing; already reverted by author.

Powered by Google App Engine
This is Rietveld 408576698