Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: extensions/renderer/resources/app_window_custom_bindings.js

Issue 1211003006: [Extensions OOPI] Update app window bindings for OOPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/render_view_observer_natives.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/app_window_custom_bindings.js
diff --git a/extensions/renderer/resources/app_window_custom_bindings.js b/extensions/renderer/resources/app_window_custom_bindings.js
index e182db73250dcd77be0229cb33ce69aac3aca5b3..cb446422e6dab565b8dfc9cfecd77612fa211193 100644
--- a/extensions/renderer/resources/app_window_custom_bindings.js
+++ b/extensions/renderer/resources/app_window_custom_bindings.js
@@ -9,7 +9,7 @@ var runtimeNatives = requireNative('runtime');
var Binding = require('binding').Binding;
var Event = require('event_bindings').Event;
var forEach = require('utils').forEach;
-var renderViewObserverNatives = requireNative('renderViewObserverNatives');
+var renderFrameObserverNatives = requireNative('renderFrameObserverNatives');
var appWindowData = null;
var currentAppWindow = null;
@@ -118,9 +118,9 @@ appWindow.registerCustomHook(function(bindingsAPI) {
var view = null;
// When window creation fails, |windowParams| will be undefined.
- if (windowParams && windowParams.viewId) {
- view = appWindowNatives.GetView(
- windowParams.viewId, windowParams.injectTitlebar);
+ if (windowParams && windowParams.frameId) {
+ view = appWindowNatives.GetFrame(
+ windowParams.frameId, windowParams.injectTitlebar);
}
if (!view) {
@@ -160,8 +160,8 @@ appWindow.registerCustomHook(function(bindingsAPI) {
}
var willCallback =
- renderViewObserverNatives.OnDocumentElementCreated(
- windowParams.viewId,
+ renderFrameObserverNatives.OnDocumentElementCreated(
+ windowParams.frameId,
function(success) {
if (success) {
callback(view.chrome.app.window.current());
« no previous file with comments | « extensions/renderer/render_view_observer_natives.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698