Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1607)

Unified Diff: extensions/renderer/dispatcher.cc

Issue 1211003006: [Extensions OOPI] Update app window bindings for OOPI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/dispatcher.cc
diff --git a/extensions/renderer/dispatcher.cc b/extensions/renderer/dispatcher.cc
index 4351b22cc2bff7341a700543ea31b98dc910c69f..7afc89bf788f64d7e7e35f37dd1b3a54680161b3 100644
--- a/extensions/renderer/dispatcher.cc
+++ b/extensions/renderer/dispatcher.cc
@@ -67,7 +67,7 @@
#include "extensions/renderer/module_system.h"
#include "extensions/renderer/print_native_handler.h"
#include "extensions/renderer/process_info_native_handler.h"
-#include "extensions/renderer/render_view_observer_natives.h"
+#include "extensions/renderer/render_frame_observer_natives.h"
#include "extensions/renderer/request_sender.h"
#include "extensions/renderer/runtime_custom_bindings.h"
#include "extensions/renderer/safe_builtins.h"
@@ -665,8 +665,8 @@ void Dispatcher::RegisterNativeHandlers(ModuleSystem* module_system,
"activityLogger",
scoped_ptr<NativeHandler>(new APIActivityLogger(context)));
module_system->RegisterNativeHandler(
- "renderViewObserverNatives",
- scoped_ptr<NativeHandler>(new RenderViewObserverNatives(context)));
+ "renderFrameObserverNatives",
+ scoped_ptr<NativeHandler>(new RenderFrameObserverNatives(context)));
// Natives used by multiple APIs.
module_system->RegisterNativeHandler(
@@ -677,10 +677,13 @@ void Dispatcher::RegisterNativeHandlers(ModuleSystem* module_system,
module_system->RegisterNativeHandler(
"app_runtime",
scoped_ptr<NativeHandler>(new AppRuntimeCustomBindings(context)));
+ // |dispatcher| is null in unit tests.
+ const ScriptContextSet* script_context_set = dispatcher ?
+ &dispatcher->script_context_set() : nullptr;
module_system->RegisterNativeHandler(
"app_window_natives",
- scoped_ptr<NativeHandler>(
- new AppWindowCustomBindings(dispatcher, context)));
+ scoped_ptr<NativeHandler>(new AppWindowCustomBindings(
+ script_context_set, context)));
module_system->RegisterNativeHandler(
"blob_natives",
scoped_ptr<NativeHandler>(new BlobNativeHandler(context)));
« no previous file with comments | « extensions/renderer/app_window_custom_bindings.cc ('k') | extensions/renderer/render_frame_observer_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698