[Extensions OOPI] Update app window bindings for OOPI

extensions/browser/app_window/app_window_registry.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/app_window/app_window_registry.h"
 
 #include <string>
 #include <vector>
 
+#include "base/strings/stringprintf.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/devtools_agent_host.h"
 #include "content/public/browser/render_process_host.h"
-#include "content/public/browser/render_view_host.h"
 #include "content/public/browser/site_instance.h"
 #include "content/public/browser/web_contents.h"
 #include "extensions/browser/app_window/app_window.h"
 #include "extensions/browser/app_window/native_app_window.h"
 #include "extensions/browser/extensions_browser_client.h"
 #include "extensions/common/extension.h"
 
 namespace extensions {
 
-namespace {
-
-// Create a key that identifies a AppWindow in a RenderViewHost across App
-// reloads. If the window was given an id in CreateParams, the key is the
-// extension id, a colon separator, and the AppWindow's |id|. If there is no
-// |id|, the chrome-extension://extension-id/page.html URL will be used. If the
-// RenderViewHost is not for a AppWindow, return an empty string.
-std::string GetWindowKeyForRenderViewHost(
-    const AppWindowRegistry* registry,
-    content::RenderViewHost* render_view_host) {
-  AppWindow* app_window =
-      registry->GetAppWindowForRenderViewHost(render_view_host);
-  if (!app_window)
-    return std::string();  // Not a AppWindow.
-
-  if (app_window->window_key().empty())
-    return app_window->web_contents()->GetURL().possibly_invalid_spec();
-
-  std::string key = app_window->extension_id();
-  key += ':';
-  key += app_window->window_key();
-  return key;
-}
-
-}  // namespace
-
 void AppWindowRegistry::Observer::OnAppWindowAdded(AppWindow* app_window) {
 }
 
 void AppWindowRegistry::Observer::OnAppWindowIconChanged(
     AppWindow* app_window) {
 }
 
 void AppWindowRegistry::Observer::OnAppWindowRemoved(AppWindow* app_window) {
 }
 
@@ skipping 81 matching lines @@
 void AppWindowRegistry::CloseAllAppWindowsForApp(const std::string& app_id) {
   const AppWindowList windows = GetAppWindowsForApp(app_id);
   for (AppWindowRegistry::const_iterator it = windows.begin();
        it != windows.end();
        ++it) {
     (*it)->GetBaseWindow()->Close();
   }
 }
 
 AppWindow* AppWindowRegistry::GetAppWindowForWebContents(
-    content::WebContents* web_contents) const {
+    const content::WebContents* web_contents) const {
   for (AppWindow* window : app_windows_) {
     if (window->web_contents() == web_contents)
       return window;
   }
   return nullptr;
 }
 
-AppWindow* AppWindowRegistry::GetAppWindowForRenderViewHost(
-    content::RenderViewHost* render_view_host) const {
-  return GetAppWindowForWebContents(
-      content::WebContents::FromRenderViewHost(render_view_host));
-}
-
 AppWindow* AppWindowRegistry::GetAppWindowForNativeWindow(
     gfx::NativeWindow window) const {
   for (AppWindowList::const_iterator i = app_windows_.begin();
        i != app_windows_.end();
        ++i) {
     if ((*i)->GetNativeWindow() == window)
       return *i;
   }
 
   return NULL;
@@ skipping 25 matching lines @@
     if ((*i)->extension_id() == app_id && (*i)->window_key() == window_key) {
       result = *i;
       if (result->GetBaseWindow()->IsActive())
         return result;
     }
   }
   return result;
 }
 
 bool AppWindowRegistry::HadDevToolsAttached(
-    content::RenderViewHost* render_view_host) const {
-  std::string key = GetWindowKeyForRenderViewHost(this, render_view_host);
+    content::WebContents* web_contents) const {
+  std::string key = GetWindowKeyForWebContents(web_contents);
   return key.empty() ? false : inspected_windows_.count(key) != 0;
 }
 
 void AppWindowRegistry::OnDevToolsStateChanged(
     content::DevToolsAgentHost* agent_host,
     bool attached) {
   content::WebContents* web_contents = agent_host->GetWebContents();
   // Ignore unrelated notifications.
   if (!web_contents || web_contents->GetBrowserContext() != context_)
     return;
 
-  std::string key =
-      GetWindowKeyForRenderViewHost(this, web_contents->GetRenderViewHost());
+  std::string key = GetWindowKeyForWebContents(web_contents);
   if (key.empty())
     return;
 
   if (attached)
     inspected_windows_.insert(key);
   else
     inspected_windows_.erase(key);
 }
 
 void AppWindowRegistry::AddAppWindowToList(AppWindow* app_window) {
   const AppWindowList::iterator it =
       std::find(app_windows_.begin(), app_windows_.end(), app_window);
   if (it != app_windows_.end())
     return;
   app_windows_.push_back(app_window);
 }
 
 void AppWindowRegistry::BringToFront(AppWindow* app_window) {
   const AppWindowList::iterator it =
       std::find(app_windows_.begin(), app_windows_.end(), app_window);
   if (it != app_windows_.end())
     app_windows_.erase(it);
   app_windows_.push_front(app_window);
 }
 
+std::string AppWindowRegistry::GetWindowKeyForWebContents(
+    content::WebContents* web_contents) const {
+  AppWindow* app_window = GetAppWindowForWebContents(web_contents);
+  if (!app_window)
+    return std::string();  // Not an AppWindow.
+
+  if (app_window->window_key().empty())
+    return web_contents->GetURL().possibly_invalid_spec();
+
+  return base::StringPrintf("%s:%s", app_window->extension_id().c_str(),
+                            app_window->window_key().c_str());
+}
+
 ///////////////////////////////////////////////////////////////////////////////
 // Factory boilerplate
 
 // static
 AppWindowRegistry* AppWindowRegistry::Factory::GetForBrowserContext(
     content::BrowserContext* context,
     bool create) {
   return static_cast<AppWindowRegistry*>(
       GetInstance()->GetServiceForBrowserContext(context, create));
 }
@@ skipping 21 matching lines @@
 bool AppWindowRegistry::Factory::ServiceIsNULLWhileTesting() const {
   return false;
 }
 
 content::BrowserContext* AppWindowRegistry::Factory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return ExtensionsBrowserClient::Get()->GetOriginalContext(context);
 }
 
 }  // namespace extensions