Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1210973002: Revert of [Android] Add a Java version of net::test_server::EmbeddedTestServer. (Closed)

Created:
5 years, 6 months ago by jbudorick
Modified:
5 years, 6 months ago
Reviewers:
Yaron, mef
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add a Java version of net::test_server::EmbeddedTestServer. (patchset #7 id:120001 of https://codereview.chromium.org/1174613002/) Reason for revert: broke main waterfall: http://build.chromium.org/p/chromium/builders/Android/builds/42187 Original issue's description: > [Android] Add a Java version of net::test_server::EmbeddedTestServer. > > Notably, this CL does not: > - convert ChromeInstrumentationTestRunner's TestHttpServer to use this > - convert cronet's NativeTestServer to use this > > Those can be done separately. > > BUG=488192 > > Committed: https://crrev.com/d58755d3bb7ead19d8ad909e4455b14857fe6d10 > Cr-Commit-Position: refs/heads/master@{#336159} TBR=mef@chromium.org,yfriedman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488192 Committed: https://crrev.com/6a6cb7e15a0b04ad92199ac1e5fb5b694adc8db6 Cr-Commit-Position: refs/heads/master@{#336165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -307 lines) Patch
M base/android/java/src/org/chromium/base/ThreadUtils.java View 1 chunk +0 lines, -1 line 0 comments Download
M net/android/keystore_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 5 chunks +8 lines, -12 lines 0 comments Download
D net/test/android/javatests/src/org/chromium/net/test/EmbeddedTestServer.java View 1 chunk +0 lines, -111 lines 0 comments Download
D net/test/android/net_test_jni_onload.h View 1 chunk +0 lines, -19 lines 0 comments Download
D net/test/android/net_test_jni_onload.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D net/test/embedded_test_server/android/embedded_test_server_android.h View 1 chunk +0 lines, -51 lines 0 comments Download
D net/test/embedded_test_server/android/embedded_test_server_android.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M net/test/embedded_test_server/embedded_test_server.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Add a Java version of net::test_server::EmbeddedTestServer.
5 years, 6 months ago (2015-06-25 15:43:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210973002/1
5 years, 6 months ago (2015-06-25 15:44:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 15:45:43 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 15:46:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a6cb7e15a0b04ad92199ac1e5fb5b694adc8db6
Cr-Commit-Position: refs/heads/master@{#336165}

Powered by Google App Engine
This is Rietveld 408576698