chrome/browser/spellchecker/spellcheck_message_filter.cc - Issue 1210943008: Patch 2: Added a preprocessor flag for platform spellcheck.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter.cc

Issue 1210943008: Patch 2: Added a preprocessor flag for platform spellcheck. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_spellcheck_flag

Patch Set: Declared the preprocessor flag in build/config/features.gni Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java ('k') | chrome/browser/spellchecker/spellcheck_platform_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/spellchecker/spellcheck_message_filter.cc

diff --git a/chrome/browser/spellchecker/spellcheck_message_filter.cc b/chrome/browser/spellchecker/spellcheck_message_filter.cc

index d29c5141bdc7e1d304b7a6e8de7e56720dd6187a..5c39888aece4d59c1a996e2f0a3135bce69322e5 100644

--- a/chrome/browser/spellchecker/spellcheck_message_filter.cc

+++ b/chrome/browser/spellchecker/spellcheck_message_filter.cc

@@ -37,7 +37,7 @@ void SpellCheckMessageFilter::OverrideThreadForMessage(

message.type() == SpellCheckHostMsg_NotifyChecked::ID ||

message.type() == SpellCheckHostMsg_RespondDocumentMarkers::ID)

*thread = BrowserThread::UI;

-#if !defined(OS_MACOSX)

+#if !defined(USE_PLATFORM_SPELLCHECKER)

if (message.type() == SpellCheckHostMsg_CallSpellingService::ID)

*thread = BrowserThread::UI;

#endif

@@ -52,7 +52,7 @@ bool SpellCheckMessageFilter::OnMessageReceived(const IPC::Message& message) {

OnNotifyChecked)

IPC_MESSAGE_HANDLER(SpellCheckHostMsg_RespondDocumentMarkers,

OnRespondDocumentMarkers)

-#if !defined(OS_MACOSX)

+#if !defined(USE_PLATFORM_SPELLCHECKER)

IPC_MESSAGE_HANDLER(SpellCheckHostMsg_CallSpellingService,

OnCallSpellingService)

#endif

@@ -106,7 +106,7 @@ void SpellCheckMessageFilter::OnRespondDocumentMarkers(

render_process_id_, markers);

}

-#if !defined(OS_MACOSX)

+#if !defined(USE_PLATFORM_SPELLCHECKER)

void SpellCheckMessageFilter::OnCallSpellingService(

int route_id,

int identifier,