Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: build/common.gypi

Issue 1210943008: Patch 2: Added a preprocessor flag for platform spellcheck. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_spellcheck_flag
Patch Set: Declared the preprocessor flag in build/config/features.gni Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data 560 # Only evaluated if cld_version == 2 or if building the CLD2 dynamic data
561 # tool explicitly. 561 # tool explicitly.
562 # See third_party/cld_2/cld_2.gyp for more information. 562 # See third_party/cld_2/cld_2.gyp for more information.
563 # 0: Small tables, lower accuracy 563 # 0: Small tables, lower accuracy
564 # 2: Large tables, high accuracy 564 # 2: Large tables, high accuracy
565 'cld2_table_size%': 2, 565 'cld2_table_size%': 2,
566 566
567 # Enable spell checker. 567 # Enable spell checker.
568 'enable_spellcheck%': 1, 568 'enable_spellcheck%': 1,
569 569
570 # Use the operating system spellchecker, e.g. NSSpellChecker on Mac or
571 # SpellCheckerSession on Android.
572 'use_platform_spellchecker%': 0,
573
570 # Webrtc compilation is enabled by default. Set to 0 to disable. 574 # Webrtc compilation is enabled by default. Set to 0 to disable.
571 'enable_webrtc%': 1, 575 'enable_webrtc%': 1,
572 576
573 # Media router support is enabled by default. Set to 0 to disable. 577 # Media router support is enabled by default. Set to 0 to disable.
574 'enable_media_router%': 1, 578 'enable_media_router%': 1,
575 579
576 # Enables use of the session service, which is enabled by default. 580 # Enables use of the session service, which is enabled by default.
577 # Support for disabling depends on the platform. 581 # Support for disabling depends on the platform.
578 'enable_session_service%': 1, 582 'enable_session_service%': 1,
579 583
(...skipping 232 matching lines...) Expand 10 before | Expand all | Expand 10 after
812 'remoting%': 0, 816 'remoting%': 0,
813 'arm_neon%': 0, 817 'arm_neon%': 0,
814 'arm_neon_optional%': 1, 818 'arm_neon_optional%': 1,
815 'native_memory_pressure_signals%': 1, 819 'native_memory_pressure_signals%': 1,
816 'enable_basic_printing%': 1, 820 'enable_basic_printing%': 1,
817 'enable_print_preview%': 0, 821 'enable_print_preview%': 0,
818 'enable_task_manager%':0, 822 'enable_task_manager%':0,
819 'video_hole%': 1, 823 'video_hole%': 1,
820 }], 824 }],
821 825
826 # OSX has a built-in spellchecker can be utilized.
827 ['OS=="mac"', {
828 'use_platform_spellchecker%': 1,
829 }],
830
822 # Android OS includes support for proprietary codecs regardless of 831 # Android OS includes support for proprietary codecs regardless of
823 # building Chromium or Google Chrome. We also ship Google Chrome and 832 # building Chromium or Google Chrome. We also ship Google Chrome and
824 # Chromecast with proprietary codecs. 833 # Chromecast with proprietary codecs.
825 ['OS=="android" or branding=="Chrome" or chromecast==1', { 834 ['OS=="android" or branding=="Chrome" or chromecast==1', {
826 'proprietary_codecs%': 1, 835 'proprietary_codecs%': 1,
827 }, { 836 }, {
828 'proprietary_codecs%': 0, 837 'proprietary_codecs%': 0,
829 }], 838 }],
830 839
831 ['OS=="mac" or OS=="ios"', { 840 ['OS=="mac" or OS=="ios"', {
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
1187 'enable_background%': '<(enable_background)', 1196 'enable_background%': '<(enable_background)',
1188 'linux_use_bundled_gold%': '<(linux_use_bundled_gold)', 1197 'linux_use_bundled_gold%': '<(linux_use_bundled_gold)',
1189 'linux_use_bundled_binutils%': '<(linux_use_bundled_binutils)', 1198 'linux_use_bundled_binutils%': '<(linux_use_bundled_binutils)',
1190 'linux_use_gold_flags%': '<(linux_use_gold_flags)', 1199 'linux_use_gold_flags%': '<(linux_use_gold_flags)',
1191 'linux_use_debug_fission%': '<(linux_use_debug_fission)', 1200 'linux_use_debug_fission%': '<(linux_use_debug_fission)',
1192 'use_canvas_skia%': '<(use_canvas_skia)', 1201 'use_canvas_skia%': '<(use_canvas_skia)',
1193 'test_isolation_mode%': '<(test_isolation_mode)', 1202 'test_isolation_mode%': '<(test_isolation_mode)',
1194 'enable_basic_printing%': '<(enable_basic_printing)', 1203 'enable_basic_printing%': '<(enable_basic_printing)',
1195 'enable_print_preview%': '<(enable_print_preview)', 1204 'enable_print_preview%': '<(enable_print_preview)',
1196 'enable_spellcheck%': '<(enable_spellcheck)', 1205 'enable_spellcheck%': '<(enable_spellcheck)',
1206 'use_platform_spellchecker%': '<(use_platform_spellchecker)',
1197 'enable_google_now%': '<(enable_google_now)', 1207 'enable_google_now%': '<(enable_google_now)',
1198 'cld_version%': '<(cld_version)', 1208 'cld_version%': '<(cld_version)',
1199 'cld2_table_size%': '<(cld2_table_size)', 1209 'cld2_table_size%': '<(cld2_table_size)',
1200 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)', 1210 'enable_captive_portal_detection%': '<(enable_captive_portal_detection)',
1201 'disable_file_support%': '<(disable_file_support)', 1211 'disable_file_support%': '<(disable_file_support)',
1202 'disable_ftp_support%': '<(disable_ftp_support)', 1212 'disable_ftp_support%': '<(disable_ftp_support)',
1203 'use_icu_alternatives_on_android%': '<(use_icu_alternatives_on_android)', 1213 'use_icu_alternatives_on_android%': '<(use_icu_alternatives_on_android)',
1204 'enable_task_manager%': '<(enable_task_manager)', 1214 'enable_task_manager%': '<(enable_task_manager)',
1205 'sas_dll_path%': '<(sas_dll_path)', 1215 'sas_dll_path%': '<(sas_dll_path)',
1206 'wix_path%': '<(wix_path)', 1216 'wix_path%': '<(wix_path)',
(...skipping 1771 matching lines...) Expand 10 before | Expand all | Expand 10 after
2978 'defines': ['ENABLE_BASIC_PRINTING=1'], 2988 'defines': ['ENABLE_BASIC_PRINTING=1'],
2979 }], 2989 }],
2980 ['enable_print_preview==1', { 2990 ['enable_print_preview==1', {
2981 # Enable printing with print preview. 2991 # Enable printing with print preview.
2982 # Can be defined without ENABLE_BASIC_PRINTING. 2992 # Can be defined without ENABLE_BASIC_PRINTING.
2983 'defines': ['ENABLE_PRINT_PREVIEW=1'], 2993 'defines': ['ENABLE_PRINT_PREVIEW=1'],
2984 }], 2994 }],
2985 ['enable_spellcheck==1', { 2995 ['enable_spellcheck==1', {
2986 'defines': ['ENABLE_SPELLCHECK=1'], 2996 'defines': ['ENABLE_SPELLCHECK=1'],
2987 }], 2997 }],
2998 ['use_platform_spellchecker', {
2999 'defines': ['USE_PLATFORM_SPELLCHECKER=1'],
3000 }],
2988 ['enable_captive_portal_detection==1', { 3001 ['enable_captive_portal_detection==1', {
2989 'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'], 3002 'defines': ['ENABLE_CAPTIVE_PORTAL_DETECTION=1'],
2990 }], 3003 }],
2991 ['enable_app_list==1', { 3004 ['enable_app_list==1', {
2992 'defines': ['ENABLE_APP_LIST=1'], 3005 'defines': ['ENABLE_APP_LIST=1'],
2993 }], 3006 }],
2994 ['enable_settings_app==1', { 3007 ['enable_settings_app==1', {
2995 'defines': ['ENABLE_SETTINGS_APP=1'], 3008 'defines': ['ENABLE_SETTINGS_APP=1'],
2996 }], 3009 }],
2997 ['disable_file_support==1', { 3010 ['disable_file_support==1', {
(...skipping 3199 matching lines...) Expand 10 before | Expand all | Expand 10 after
6197 # settings in target dicts. SYMROOT is a special case, because many other 6210 # settings in target dicts. SYMROOT is a special case, because many other
6198 # Xcode variables depend on it, including variables such as 6211 # Xcode variables depend on it, including variables such as
6199 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6212 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6200 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6213 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6201 # files to appear (when present) in the UI as actual files and not red 6214 # files to appear (when present) in the UI as actual files and not red
6202 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6215 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6203 # and therefore SYMROOT, needs to be set at the project level. 6216 # and therefore SYMROOT, needs to be set at the project level.
6204 'SYMROOT': '<(DEPTH)/xcodebuild', 6217 'SYMROOT': '<(DEPTH)/xcodebuild',
6205 }, 6218 },
6206 } 6219 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698