Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1210903004: Implement hanja counter styles (Closed)

Created:
5 years, 6 months ago by rwlbuis
Modified:
5 years, 6 months ago
Reviewers:
tkent, kojii
CC:
blink-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org, dglazkov+blink, blink-reviews-rendering, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, dshwang, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Implement hanja counter styles Implement both the formal and informal hanja counter style. The patch follows the korean specific steps in the algorithm for extended counter styles [1]. Add the corresponding tests from the official test repository [2]. Behavior matches Firefox. [1] http://www.w3.org/TR/2013/WD-css-counter-styles-3-20130718/#extended-cjk [2] https://github.com/w3c/csswg-test/tree/master/css-counter-styles-3/i18n Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197870

Patch Set 1 #

Patch Set 2 : Fix one handling #

Patch Set 3 : Fix remaining tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -83 lines) Patch
A + LayoutTests/fast/lists/css3-counter-styles-057.html View 3 chunks +5 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-057-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-058.html View 4 chunks +16 lines, -13 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-058-expected.txt View 1 1 chunk +10 lines, -10 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-059.html View 1 2 1 chunk +6 lines, -9 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-059-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-060.html View 3 chunks +5 lines, -4 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-060-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-061.html View 3 chunks +5 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-061-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-062.html View 4 chunks +9 lines, -6 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-062-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/fast/lists/css3-counter-styles-063.html View 1 chunk +59 lines, -0 lines 0 comments Download
A LayoutTests/fast/lists/css3-counter-styles-063-expected.txt View 1 chunk +29 lines, -0 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-064.html View 1 2 1 chunk +6 lines, -9 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-064-expected.txt View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-065.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-065-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-066.html View 3 chunks +6 lines, -3 lines 0 comments Download
A + LayoutTests/fast/lists/css3-counter-styles-066-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/fast/lists/li-values-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutListMarker.cpp View 1 2 9 chunks +43 lines, -5 lines 0 comments Download
M Source/core/paint/ListMarkerPainter.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/style/ComputedStyleConstants.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rwlbuis
PTAL. Note that I think it may be suitable if one of you could add ...
5 years, 6 months ago (2015-06-25 22:18:18 UTC) #2
tkent
lgtm
5 years, 6 months ago (2015-06-25 23:22:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210903004/30001
5 years, 6 months ago (2015-06-25 23:22:37 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 00:09:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:30001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197870

Powered by Google App Engine
This is Rietveld 408576698