Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Unified Diff: Source/devtools/front_end/audits/AuditRules.js

Issue 1210893002: DevTools: [CSS] introduce strong types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/audits/AuditRules.js
diff --git a/Source/devtools/front_end/audits/AuditRules.js b/Source/devtools/front_end/audits/AuditRules.js
index 943bf82c663e5d627e394dbf1603c6c6353e2585..b6036a5bdd9f735bb9e4323669cd14b5e8d0c284 100644
--- a/Source/devtools/front_end/audits/AuditRules.js
+++ b/Source/devtools/front_end/audits/AuditRules.js
@@ -986,16 +986,24 @@ WebInspector.AuditRules.ImageDimensionsRule.prototype = {
}
var targetResult = {};
- function inlineCallback(inlineStyle, attributesStyle)
+ /**
+ * @param {?WebInspector.CSSStyleModel.InlineStyleResult} inlineStyleResult
+ */
+ function inlineCallback(inlineStyleResult)
{
- targetResult.inlineStyle = inlineStyle;
- targetResult.attributesStyle = attributesStyle;
+ if (!inlineStyleResult)
+ return;
+ targetResult.inlineStyle = inlineStyleResult.inlineStyle;
+ targetResult.attributesStyle = inlineStyleResult.attributesStyle;
}
- function matchedCallback(result)
+ /**
+ * @param {?WebInspector.CSSStyleModel.MatchedStyleResult} matchedStyleResult
+ */
+ function matchedCallback(matchedStyleResult)
{
- if (result)
- targetResult.matchedCSSRules = result.matchedCSSRules;
+ if (matchedStyleResult)
+ targetResult.matchedCSSRules = matchedStyleResult.matchedCSSRules;
}
if (!nodeIds || !nodeIds.length)
« no previous file with comments | « Source/core/inspector/InspectorCSSAgent.cpp ('k') | Source/devtools/front_end/elements/MetricsSidebarPane.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698