Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 1210893002: DevTools: [CSS] introduce strong types (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [CSS] introduce strong types The patch: - introduce WI.CSSStyleModel.InlineStyleResult type, a single container type for getInlineStyle command results. - setup a strong type for getMatchedStyles command - remove cssFamilyName return value from getPlatformFonts R=pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197824

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -63 lines) Patch
M LayoutTests/inspector/elements/styles-1/add-new-rule-inline-style-csp.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/elements/styles-1/edit-value-inside-property.html View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/audits/AuditRules.js View 1 chunk +14 lines, -6 lines 0 comments Download
M Source/devtools/front_end/elements/MetricsSidebarPane.js View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/devtools/front_end/elements/PlatformFontsWidget.js View 1 chunk +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 2 chunks +12 lines, -11 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 5 chunks +73 lines, -28 lines 0 comments Download
M Source/devtools/protocol.json View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
lushnikov
ptal
4 years, 10 months ago (2015-06-25 13:45:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210893002/1
4 years, 10 months ago (2015-06-25 13:45:32 UTC) #3
pfeldman
lgtm
4 years, 10 months ago (2015-06-25 14:10:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2015-06-25 15:02:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210893002/1
4 years, 10 months ago (2015-06-25 15:21:21 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 15:24:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197824

Powered by Google App Engine
This is Rietveld 408576698