Service Worker: Fix getRegistrations.html layout test.

Service Worker: Fix getRegistrations.html layout test.

Serialize the registration and unregistration sequence between top-level window
and its iframe so that the registration object in the iframe cannot be
derefenced before created.

Also this CL improves the performace of the registration purging operations at
the beginning of the test by using Promise.all(unreg_promises) instead of
serializing the promises. It should be noted that registration.unregister() 
promises resolve before the corresponding registrations are actually deleted 
from the storage as per spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#unregister-algorithm.
Thus this test made the registration purging step be waiting until the 
corresponding registrations are actually deleted from the storage.

BUG=502125
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197899

[jungkees, 2015-06-25 13:35:34]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, kinuko@chromium.org, michaeln@chromium.org,
nhiroki@chromium.org

[jungkees, 2015-06-25 13:39:13]

getRegistrations.html had a message sync issue between the top-level window and
the iframe. Tried to resolve the issue. PTAL

[falken, 2015-06-26 00:56:47]

lgtm. Can you also remove http/tests/serviceworker/getregistrations.html from
TestExpectations and SlowTests?

[jungkees, 2015-06-26 01:10:58]

I'm not really familiar with "TestExpectations and SlowTests". Could you give me
any pointers?

[falken, 2015-06-26 01:13:56]

On 2015/06/26 01:10:58, jungkees wrote:
> I'm not really familiar with "TestExpectations and SlowTests". Could you give
me
> any pointers?

third_party/WebKit/LayoutTests/TestExpectations and
third_party/WebKit/LayoutTests/SlowTests have expectations for misbehaving
tests. Currently there are lines:

crbug.com/503175 http/tests/serviceworker/getregistrations.html [ Pass Failure ]
and
crbug.com/503175 http/tests/serviceworker/getregistrations.html [ Slow ]

We should remove these lines as this patch is expected to fix the tests. See:
https://www.chromium.org/developers/testing/webkit-layout-tests/testexpectations

[jungkees, 2015-06-26 01:28:41]

Addressed. Thanks for the pointers!

[jungkees, 2015-06-26 01:28:50]

The CQ bit was checked by jungkee.song@samsung.com

[jungkees, 2015-06-26 01:28:50]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1210883002/#ps20001
(title: "Remove lines from TestExpectations and SlowTests.")

[commit-bot: I haz the power, 2015-06-26 01:29:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210883002/20001

[jungkees, 2015-06-26 04:25:51]

The CQ bit was unchecked by jungkee.song@samsung.com

[jungkees, 2015-06-26 06:25:25]

falken@ I just made a snapshot having addressed our discussion about
guaranteeing purging registrations step. PTAL

[falken, 2015-06-26 07:10:14]

looks good but TestExpectations seems not uploaded correctly

https://codereview.chromium.org/1210883002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/getregistrations.html (right):

https://codereview.chromium.org/1210883002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/getregistrations.html:21: timer =
setInterval(function() {
please comment why we need this

[jungkees, 2015-06-26 07:42:37]

Addressed the comment. I'll proceed with the commit as we discussed.

https://codereview.chromium.org/1210883002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/getregistrations.html (right):

https://codereview.chromium.org/1210883002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/getregistrations.html:21: timer =
setInterval(function() {
Added the comment.

[jungkees, 2015-06-26 07:43:54]

The CQ bit was checked by jungkee.song@samsung.com

[jungkees, 2015-06-26 07:43:54]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1210883002/#ps60001
(title: "Add a comment to explain the behavior of registration.unregister() in
the test.")

[commit-bot: I haz the power, 2015-06-26 07:44:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210883002/60001

[commit-bot: I haz the power, 2015-06-26 07:46:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-26 07:46:51]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60893)

[falken, 2015-06-26 07:50:31]

looks like you need to rebase? also comment on the comment

https://codereview.chromium.org/1210883002/diff/60001/LayoutTests/http/tests/...
File LayoutTests/http/tests/serviceworker/getregistrations.html (right):

https://codereview.chromium.org/1210883002/diff/60001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/getregistrations.html:22: // corresponding
registrations are being delete from the storage, we
"are deleted from storage" reads nicer

https://codereview.chromium.org/1210883002/diff/60001/LayoutTests/http/tests/...
LayoutTests/http/tests/serviceworker/getregistrations.html:23: // are checking
whether the registrations have been acutally removed
acutally -> actually
maybe say: "must wait until the registrations are actually removed" to be clear
why we're polling

[jungkees, 2015-06-26 07:59:18]

Patchset #5 (id:80001) has been deleted

[jungkees, 2015-06-26 08:06:08]

Patchset #5 (id:100001) has been deleted

[jungkees, 2015-06-26 08:11:15]

Addressed the comment and rebased. Thanks.

[jungkees, 2015-06-26 08:11:36]

The CQ bit was checked by jungkee.song@samsung.com

[jungkees, 2015-06-26 08:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1210883002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-06-26 08:11:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210883002/120001

[commit-bot: I haz the power, 2015-06-26 09:22:22]

Committed patchset #5 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197899