Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issue 1210873007: X87: [strong] Implement strong property access semantics. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [strong] Implement strong property access semantics. port 7281f8015181736703d3663c9c570be537f008c1 (r29384) Fix a bug in R29384. original commit message: Revert "Revert relanded strong property access CL" Regression issues should be solved. Initial patchset is the original, subsequent patchsets are the fixing modifications. This reverts commit 4ac7be56568f0ac71e7bf10e8bec33c33893e5b5. BUG= Committed: https://crrev.com/70502d166f49950bf4db5e55a0afb2910713f090 Cr-Commit-Position: refs/heads/master@{#29434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-07-02 02:43:10 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-02 03:39:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210873007/1
5 years, 5 months ago (2015-07-02 03:39:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-02 04:27:20 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 04:27:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70502d166f49950bf4db5e55a0afb2910713f090
Cr-Commit-Position: refs/heads/master@{#29434}

Powered by Google App Engine
This is Rietveld 408576698