CacheStorage: Enable Cache::putImpl to receive multiple requests/responses

CacheStorage: Enable Cache::putImpl to receive multiple requests/responses

This CL enables Cache::putImpl to receive multiple requests and responses for
supporting addAll() in a subsequent CL. This should not change behavior of put()
and add().

BUG=427652
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197958

[nhiroki, 2015-06-26 05:20:16]

Patchset #1 (id:1) has been deleted

[nhiroki, 2015-06-26 05:47:58]

nhiroki@chromium.org changed reviewers:
+ jkarlin@chromium.org

[nhiroki, 2015-06-26 05:55:17]

Hi jkarin@, can you review this?

The main patch to implement addAll() is here:
https://codereview.chromium.org/1124403005/

Thanks!

[jkarlin, 2015-06-26 20:26:56]

lgtm

[nhiroki, 2015-06-29 02:26:34]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2015-06-29 02:26:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210873004/20001

[commit-bot: I haz the power, 2015-06-29 04:31:36]

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197958

[sof, 2015-06-30 09:46:46]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-06-30 09:46:47]

https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
Source/modules/cachestorage/Cache.cpp:198:
m_cache->webCache()->dispatchBatch(new CallbackPromiseAdapter<void,
CacheStorageError>(m_resolver), m_batchOperations);
Where is m_resolver resolved or cleared?

[nhiroki, 2015-07-01 02:02:20]

https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
File Source/modules/cachestorage/Cache.cpp (right):

https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
Source/modules/cachestorage/Cache.cpp:198:
m_cache->webCache()->dispatchBatch(new CallbackPromiseAdapter<void,
CacheStorageError>(m_resolver), m_batchOperations);
On 2015/06/30 09:46:46, sof wrote:
> Where is m_resolver resolved or cleared?

m_resolver is resolved in CallbackPromiseAdapter<void, T>::onSuccess()[1] called
from CacheStorageDispatcher::OnCacheBatchSuccess()[2].

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
[2]
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/c...

[sof, 2015-07-01 06:41:05]

On 2015/07/01 02:02:20, nhiroki wrote:
>
https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
> File Source/modules/cachestorage/Cache.cpp (right):
> 
>
https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
> Source/modules/cachestorage/Cache.cpp:198:
> m_cache->webCache()->dispatchBatch(new CallbackPromiseAdapter<void,
> CacheStorageError>(m_resolver), m_batchOperations);
> On 2015/06/30 09:46:46, sof wrote:
> > Where is m_resolver resolved or cleared?
> 
> m_resolver is resolved in CallbackPromiseAdapter<void, T>::onSuccess()[1]
called
> from CacheStorageDispatcher::OnCacheBatchSuccess()[2].
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> [2]
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/c...

Thanks for the code xrefs, that covers the correct resolution in the common
case.

However, I'm seeing ~ScriptPromiseResolver's assert failing about an unresolved
resolver, which started happening around when this CL landed --


http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...

[nhiroki, 2015-07-01 07:42:14]

On 2015/07/01 06:41:05, sof wrote:
> On 2015/07/01 02:02:20, nhiroki wrote:
> >
>
https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
> > File Source/modules/cachestorage/Cache.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
> > Source/modules/cachestorage/Cache.cpp:198:
> > m_cache->webCache()->dispatchBatch(new CallbackPromiseAdapter<void,
> > CacheStorageError>(m_resolver), m_batchOperations);
> > On 2015/06/30 09:46:46, sof wrote:
> > > Where is m_resolver resolved or cleared?
> > 
> > m_resolver is resolved in CallbackPromiseAdapter<void, T>::onSuccess()[1]
> called
> > from CacheStorageDispatcher::OnCacheBatchSuccess()[2].
> > 
> > [1]
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > [2]
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/c...
> 
> Thanks for the code xrefs, that covers the correct resolution in the common
> case.
> 
> However, I'm seeing ~ScriptPromiseResolver's assert failing about an
unresolved
> resolver, which started happening around when this CL landed --
> 
> 
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...

Thanks for your information. Oh... that happens when Cache::putImpl returns
early. I'll fix it.

[nhiroki, 2015-07-01 08:24:21]

On 2015/07/01 07:42:14, nhiroki wrote:
> On 2015/07/01 06:41:05, sof wrote:
> > On 2015/07/01 02:02:20, nhiroki wrote:
> > >
> >
>
https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
> > > File Source/modules/cachestorage/Cache.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1210873004/diff/20001/Source/modules/cachesto...
> > > Source/modules/cachestorage/Cache.cpp:198:
> > > m_cache->webCache()->dispatchBatch(new CallbackPromiseAdapter<void,
> > > CacheStorageError>(m_resolver), m_batchOperations);
> > > On 2015/06/30 09:46:46, sof wrote:
> > > > Where is m_resolver resolved or cleared?
> > > 
> > > m_resolver is resolved in CallbackPromiseAdapter<void, T>::onSuccess()[1]
> > called
> > > from CacheStorageDispatcher::OnCacheBatchSuccess()[2].
> > > 
> > > [1]
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > > [2]
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/content/renderer/c...
> > 
> > Thanks for the code xrefs, that covers the correct resolution in the common
> > case.
> > 
> > However, I'm seeing ~ScriptPromiseResolver's assert failing about an
> unresolved
> > resolver, which started happening around when this CL landed --
> > 
> > 
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=htt...
> 
> Thanks for your information. Oh... that happens when Cache::putImpl returns
> early. I'll fix it.

Uploaded: https://codereview.chromium.org/1211293003/