Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 1210863002: [turbofan] Use proper eager deopts for %_ThrowNotDateError(). (Closed)

Created:
5 years, 6 months ago by Benedikt Meurer
Modified:
5 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use proper eager deopts for %_ThrowNotDateError(). R=jarin@chromium.org Committed: https://crrev.com/9ad117657bfa59454b08b877c187f1a0dcd16c67 Cr-Commit-Position: refs/heads/master@{#29309}

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : ports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -11 lines) Patch
M src/arm/full-codegen-arm.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/ast.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/linkage.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M src/compiler/linkage-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Benedikt Meurer
5 years, 6 months ago (2015-06-25 12:38:04 UTC) #1
Benedikt Meurer
Hey Jaro, Another bailout point, yeah! Please take a look. Thanks, Benedikt
5 years, 6 months ago (2015-06-25 12:38:52 UTC) #2
Jarin
lgtm
5 years, 6 months ago (2015-06-25 12:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210863002/1
5 years, 6 months ago (2015-06-25 12:42:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/3996)
5 years, 6 months ago (2015-06-25 12:50:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210863002/20001
5 years, 6 months ago (2015-06-26 05:10:38 UTC) #10
commit-bot: I haz the power
Exceeded global retry quota
5 years, 6 months ago (2015-06-26 05:22:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210863002/40001
5 years, 6 months ago (2015-06-26 05:32:24 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-26 05:56:06 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 05:56:26 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9ad117657bfa59454b08b877c187f1a0dcd16c67
Cr-Commit-Position: refs/heads/master@{#29309}

Powered by Google App Engine
This is Rietveld 408576698