Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 121083002: Resubmit of whitelist updates for Chrome OS Recovery Tool apps. (Closed)

Created:
6 years, 12 months ago by Drew Haven
Modified:
6 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, stephenlin1, nickam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Resubmit of whitelist updates for Chrome OS Recovery Tool apps. Previous CL: https://codereview.chromium.org/99463006/ BUG=329088 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M chrome/browser/resources/feedback/js/event_handler.js View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Drew Haven
This CL got reverted along with some others due to a Valgrind test failure. I'm ...
6 years, 12 months ago (2013-12-25 09:07:39 UTC) #1
asargent_no_longer_on_chrome
lgtm
6 years, 11 months ago (2014-01-03 00:53:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/121083002/1
6 years, 11 months ago (2014-01-04 01:00:54 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43261
6 years, 11 months ago (2014-01-04 01:21:37 UTC) #4
xiyuan
lgtm
6 years, 11 months ago (2014-01-06 18:15:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haven@chromium.org/121083002/1
6 years, 11 months ago (2014-01-06 18:47:43 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-06 21:19:53 UTC) #7
Message was sent while issue was closed.
Change committed as 243166

Powered by Google App Engine
This is Rietveld 408576698