Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1210813002: Debugger: remove bogus assertion in BreakLocation constructor. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: remove bogus assertion in BreakLocation constructor. Currently DebugInfo objects can be created independently from whether the debugger is active. When tearing down the isolate, we would go through DebugInfo objects and iterate through break locations, causing this assertion to fail. R=ulan@chromium.org BUG=v8:4241 LOG=N Committed: https://crrev.com/f283021f2dfb1daa0e271ac7d5b3676e39202553 Cr-Commit-Position: refs/heads/master@{#29286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/debug.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
5 years, 6 months ago (2015-06-25 09:39:36 UTC) #1
ulan
lgtm s/independelty/independently/ in the description
5 years, 6 months ago (2015-06-25 09:46:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210813002/1
5 years, 6 months ago (2015-06-25 09:48:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 10:43:39 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 10:43:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f283021f2dfb1daa0e271ac7d5b3676e39202553
Cr-Commit-Position: refs/heads/master@{#29286}

Powered by Google App Engine
This is Rietveld 408576698