Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1491)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1210743003: Video capture IPC changes. (Closed)

Created:
5 years, 5 months ago by dcheng
Modified:
5 years, 5 months ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Video capture IPC changes.

Patch Set 1 #

Patch Set 2 : moo #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -258 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/browser/media/media_internals_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.h View 4 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 9 chunks +24 lines, -67 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc View 5 chunks +27 lines, -14 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 12 chunks +33 lines, -25 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 8 chunks +35 lines, -27 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 1 chunk +0 lines, -1 line 1 comment Download
M content/common/media/media_param_traits.cc View 1 3 chunks +13 lines, -17 lines 1 comment Download
M content/common/media/video_capture_messages.h View 1 1 chunk +2 lines, -0 lines 1 comment Download
M content/common/view_messages.h View 1 1 chunk +1 line, -0 lines 1 comment Download
M media/base/video_capture_types.h View 4 chunks +20 lines, -2 lines 0 comments Download
M media/base/video_capture_types.cc View 4 chunks +66 lines, -41 lines 0 comments Download
M media/capture/screen_capture_device_core.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M media/capture/thread_safe_capture_oracle.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M media/video/capture/fake_video_capture_device.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 5 chunks +19 lines, -15 lines 0 comments Download
M media/video/capture/fake_video_capture_device_unittest.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M media/video/capture/video_capture_device.h View 1 chunk +3 lines, -2 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
5 years, 5 months ago (2015-06-25 02:00:04 UTC) #1 
https://codereview.chromium.org/1210743003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_message_filter.cc (left):

https://codereview.chromium.org/1210743003/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_message_filter.cc:40: #include
"content/common/media/media_param_traits.h"
This is the wrong place to have this #include, so I moved it to view_messages.h.

https://codereview.chromium.org/1210743003/diff/20001/content/common/media/me...
File content/common/media/media_param_traits.cc (right):

https://codereview.chromium.org/1210743003/diff/20001/content/common/media/me...
content/common/media/media_param_traits.cc:8: #include
"content/common/media/video_capture_messages.h"
This #include is needed to pull in the IPC_ENUM_TRAITS declarations.

https://codereview.chromium.org/1210743003/diff/20001/content/common/media/vi...
File content/common/media/video_capture_messages.h (right):

https://codereview.chromium.org/1210743003/diff/20001/content/common/media/vi...
content/common/media/video_capture_messages.h:26:
IPC_ENUM_TRAITS_MAX_VALUE(media::VideoPixelFormat, media::PIXEL_FORMAT_MAX - 1)
IPC_ENUM_TRAITS and friends are one of those fun macros that needs to be
included multiple times in order to generate the declarations and definitions.
You could put it elsewhere, but it's easiest to put it here.

https://codereview.chromium.org/1210743003/diff/20001/content/common/view_mes...
File content/common/view_messages.h (right):

https://codereview.chromium.org/1210743003/diff/20001/content/common/view_mes...
content/common/view_messages.h:18: #include
"content/common/media/media_param_traits.h"
This #include should be here, since there are IPC messages defined here that
require serialization routines declared here.

Powered by Google App Engine
This is Rietveld 408576698