Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(90)

Issue 1210693002: Move Handle in TeeTest and MockFetchDataLoaderClient to TestUtil (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move Handle in TeeTest and MockFetchDataLoaderClient to TestUtil Preparation for using them in ResponseTest.cpp. BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197811

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -269 lines) Patch
M Source/modules/fetch/DataConsumerHandleTestUtil.h View 1 3 chunks +110 lines, -0 lines 0 comments Download
M Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 1 chunk +183 lines, -0 lines 0 comments Download
M Source/modules/fetch/DataConsumerTeeTest.cpp View 1 11 chunks +11 lines, -243 lines 0 comments Download
M Source/modules/fetch/FetchDataLoaderTest.cpp View 3 chunks +3 lines, -26 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
hiroshige
PTAL.
4 years, 10 months ago (2015-06-24 21:18:49 UTC) #2
yhirano
https://codereview.chromium.org/1210693002/diff/1/Source/modules/fetch/DataConsumerHandleTestUtil.h File Source/modules/fetch/DataConsumerHandleTestUtil.h (right): https://codereview.chromium.org/1210693002/diff/1/Source/modules/fetch/DataConsumerHandleTestUtil.h#newcode22 Source/modules/fetch/DataConsumerHandleTestUtil.h:22: #include "wtf/Locker.h" +Deque +Vector +ThreadingPrimitives +ThreadSafeRefCounted https://codereview.chromium.org/1210693002/diff/1/Source/modules/fetch/DataConsumerHandleTestUtil.h#newcode282 Source/modules/fetch/DataConsumerHandleTestUtil.h:282: void ...
4 years, 10 months ago (2015-06-25 04:31:03 UTC) #3
hiroshige
https://codereview.chromium.org/1210693002/diff/1/Source/modules/fetch/DataConsumerHandleTestUtil.h File Source/modules/fetch/DataConsumerHandleTestUtil.h (right): https://codereview.chromium.org/1210693002/diff/1/Source/modules/fetch/DataConsumerHandleTestUtil.h#newcode22 Source/modules/fetch/DataConsumerHandleTestUtil.h:22: #include "wtf/Locker.h" On 2015/06/25 04:31:03, yhirano wrote: > +Deque ...
4 years, 10 months ago (2015-06-25 05:33:57 UTC) #4
yhirano
lgtm
4 years, 10 months ago (2015-06-25 05:40:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210693002/20001
4 years, 10 months ago (2015-06-25 09:01:45 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 10:08:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197811

Powered by Google App Engine
This is Rietveld 408576698