Improving support for WebGL2 Query objects

Improving support for WebGL2 Query objects

BUG=295792
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197784

[bajones, 2015-06-24 20:39:02]

bajones@chromium.org changed reviewers:
+ kbr@chromium.org

[bajones, 2015-06-24 20:39:02]

PTAL. New behavior tested by https://github.com/KhronosGroup/WebGL/pull/1065

[Ken Russell (switch to Gerrit), 2015-06-24 21:07:22]

LGTM. Nice work, and good work on the test.

https://codereview.chromium.org/1210673002/diff/1/Source/core/html/canvas/Web...
File Source/core/html/canvas/WebGL2RenderingContextBase.cpp (right):

https://codereview.chromium.org/1210673002/diff/1/Source/core/html/canvas/Web...
Source/core/html/canvas/WebGL2RenderingContextBase.cpp:1153:
PassRefPtrWillBeRawPtr<WebGLQuery> WebGL2RenderingContextBase::getQuery(GLenum
target, GLenum pname)
I think that we might have made a mistake when originally writing the signature
for this and some of the other "get" methods. Conceptually, since this doesn't
transfer ownership of the underlying object, they should return a raw pointer;
in this case, WebGLQuery*. Not sure whether fixing this would be compatible with
the bindings code which calls these methods, though. Could you file a bug about
looking into fixing these?

https://codereview.chromium.org/1210673002/diff/1/Source/core/html/canvas/Web...
File Source/core/html/canvas/WebGLQuery.cpp (right):

https://codereview.chromium.org/1210673002/diff/1/Source/core/html/canvas/Web...
Source/core/html/canvas/WebGLQuery.cpp:40: return;
These checks are supposed to be validated by the caller, so rather than silently
short-circuiting, I think these should be added as ASSERTs.

https://codereview.chromium.org/1210673002/diff/1/Source/core/html/canvas/Web...
File Source/core/html/canvas/WebGLQuery.h (right):

https://codereview.chromium.org/1210673002/diff/1/Source/core/html/canvas/Web...
Source/core/html/canvas/WebGLQuery.h:24: bool compatibleTarget(GLenum);
I'd suggest "isCompatibleWithTarget".

[bajones, 2015-06-24 21:21:26]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-06-24 21:21:27]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1210673002/#ps20001
(title: "Addressing some of kbr@'s nits")

[commit-bot: I haz the power, 2015-06-24 21:21:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210673002/20001

[commit-bot: I haz the power, 2015-06-24 23:11:47]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197784