Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h

Issue 1210643002: Update navigator.services API to use the new services.onconnect event [2/3]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@serviceport
Patch Set: properly run error callbacks when worker is stopped Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
diff --git a/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h b/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
index 4e0239f8c4df9fba0e3b97625c28d9490961aab0..cd935fb7ff50bbb41daa8104051be5c8c0174277 100644
--- a/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
+++ b/content/browser/navigator_connect/navigator_connect_service_worker_service_factory.h
@@ -8,6 +8,7 @@
#include <map>
#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
#include "content/common/service_worker/service_worker_status_code.h"
#include "content/public/browser/navigator_connect_service_factory.h"
@@ -42,14 +43,16 @@ class NavigatorConnectServiceWorkerServiceFactory
ServiceWorkerStatusCode status,
const scoped_refptr<ServiceWorkerRegistration>& registration);
- // Callback called when the service worker finished handling the cross origin
+ // Callback called when the service worker finished handling the service port
// connection event.
void OnConnectResult(
const ConnectCallback& callback,
const NavigatorConnectClient& client,
const scoped_refptr<ServiceWorkerRegistration>& registration,
ServiceWorkerStatusCode status,
- bool accept_connection);
+ bool accept_connection,
+ const base::string16& name,
+ const base::string16& data);
scoped_refptr<ServiceWorkerContextWrapper> service_worker_context_;
base::WeakPtrFactory<NavigatorConnectServiceWorkerServiceFactory>
« no previous file with comments | « no previous file | content/browser/navigator_connect/navigator_connect_service_worker_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698