Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores

Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores

It's useful for the megamorphic keyed store case to not require a
vector and slot as input. Analogous to the load case, we have a dummy
one-ic-slot vector to aid. Since the only kind of MISS is for
megamorphic cache stub failures, we don't need the real vector.
The reason is that megamorphic cache stub failures don't result in any
change to the type feedback vector state.

BUG=
R=jkummerow@chromium.org

Committed: https://crrev.com/9e7af9efc5857b3c7e23a77d257f3dfbea597753
Cr-Commit-Position: refs/heads/master@{#29280}

[mvstanton, 2015-06-24 15:15:14]

mvstanton@chromium.org changed reviewers:
+ jkummerow@chromium.org

[mvstanton, 2015-06-24 15:15:14]

Hi Jakob,
It turns out I do have a quick CL in case you have time today, thx for the help,
--Michael

[Jakob Kummerow, 2015-06-24 15:29:34]

LGTM with comments. The naming suggestion applies to all platforms.

https://codereview.chromium.org/1210583002/diff/1/src/ic/arm/ic-arm.cc
File src/ic/arm/ic-arm.cc (right):

https://codereview.chromium.org/1210583002/diff/1/src/ic/arm/ic-arm.cc#newcod...
src/ic/arm/ic-arm.cc:676:
masm->isolate()->factory()->keyed_load_dummy_vector());
keyed *load* dummy vector?! Oh man, you're full of surprises!

https://codereview.chromium.org/1210583002/diff/1/src/ic/arm64/ic-arm64.cc
File src/ic/arm64/ic-arm64.cc (right):

https://codereview.chromium.org/1210583002/diff/1/src/ic/arm64/ic-arm64.cc#ne...
src/ic/arm64/ic-arm64.cc:674:
masm->isolate()->factory()->keyed_load_dummy_vector());
s/load/store/

https://codereview.chromium.org/1210583002/diff/1/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):

https://codereview.chromium.org/1210583002/diff/1/src/ic/x64/ic-x64.cc#newcod...
src/ic/x64/ic-x64.cc:567: int int_slot =
dummy_vector->GetIndex(FeedbackVectorICSlot(0));
nit: naming suggestion: s/int_slot/slot_index/

[mvstanton, 2015-06-25 07:37:33]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-06-25 07:37:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1210583002/#ps40001
(title: "REBASE.")

[mvstanton, 2015-06-25 07:38:00]

Thanks!
--Michael

https://codereview.chromium.org/1210583002/diff/1/src/ic/arm/ic-arm.cc
File src/ic/arm/ic-arm.cc (right):

https://codereview.chromium.org/1210583002/diff/1/src/ic/arm/ic-arm.cc#newcod...
src/ic/arm/ic-arm.cc:676:
masm->isolate()->factory()->keyed_load_dummy_vector());
On 2015/06/24 15:29:34, Jakob wrote:
> keyed *load* dummy vector?! Oh man, you're full of surprises!

Keeping you on your toes ;). Thanks.

https://codereview.chromium.org/1210583002/diff/1/src/ic/x64/ic-x64.cc
File src/ic/x64/ic-x64.cc (right):

https://codereview.chromium.org/1210583002/diff/1/src/ic/x64/ic-x64.cc#newcod...
src/ic/x64/ic-x64.cc:567: int int_slot =
dummy_vector->GetIndex(FeedbackVectorICSlot(0));
On 2015/06/24 15:29:34, Jakob wrote:
> nit: naming suggestion: s/int_slot/slot_index/

Done.

[mvstanton, 2015-06-25 08:30:04]

The CQ bit was unchecked by mvstanton@chromium.org

[mvstanton, 2015-06-25 08:30:05]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2015-06-25 08:36:35]

Committed patchset #3 (id:40001) manually as
9e7af9efc5857b3c7e23a77d257f3dfbea597753 (presubmit successful).

[commit-bot: I haz the power, 2015-06-25 08:36:41]

Patchset 3 (id:??) landed as
https://crrev.com/9e7af9efc5857b3c7e23a77d257f3dfbea597753
Cr-Commit-Position: refs/heads/master@{#29280}