Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1292)

Issue 1210533003: Use C runtime functions for ThrowNewXXError desugarings. (Closed)

Created:
5 years, 6 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 6 months ago
Reviewers:
adamk, arv (Not doing code reviews)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use C runtime functions for ThrowNewXXError desugarings. JS runtime function calls cause Hydrogen to bail out. R=adamk@chromiunm.org,arv@chromium.org Committed: https://crrev.com/c09268f2e127b9bf5e96fcb576286c851575679d Cr-Commit-Position: refs/heads/master@{#29260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dmitry Lomov (no reviews)
PTAL. Sad panda.
5 years, 6 months ago (2015-06-24 15:56:09 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210533003/1
5 years, 6 months ago (2015-06-24 15:56:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-24 16:25:36 UTC) #5
arv (Not doing code reviews)
LGTM
5 years, 6 months ago (2015-06-24 16:32:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210533003/1
5 years, 6 months ago (2015-06-24 16:53:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 16:54:56 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 16:55:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c09268f2e127b9bf5e96fcb576286c851575679d
Cr-Commit-Position: refs/heads/master@{#29260}

Powered by Google App Engine
This is Rietveld 408576698