Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1210523003: Crash if UTS46 data doesn't load at startup (Closed)

Created:
5 years, 6 months ago by Elly Fong-Jones
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Crash if UTS46 data doesn't load at startup This check should not fail in Chrome; if loads were failing, we would see crashes all over Chrome when the data was later accessed. In CrNet the data is shipped separately so loads might fail, in which case it is better to crash now rather than when attempting to navigate to a unicode URL. BUG=None Committed: https://crrev.com/c9547bec4f1bd1072083163a4a106ab5ffea62c1 Cr-Commit-Position: refs/heads/master@{#335958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M url/url_canon_icu.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Elly Fong-Jones
jungshik: PTAL?
5 years, 6 months ago (2015-06-24 15:06:16 UTC) #2
jungshik at Google
On 2015/06/24 15:06:16, Elly Jones wrote: > jungshik: PTAL? Lgtm. The cl description is a ...
5 years, 6 months ago (2015-06-24 15:30:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210523003/1
5 years, 6 months ago (2015-06-24 16:44:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/73625)
5 years, 6 months ago (2015-06-24 16:51:06 UTC) #7
brettw
lgtm
5 years, 6 months ago (2015-06-24 17:37:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210523003/1
5 years, 6 months ago (2015-06-24 17:44:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 18:38:06 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 18:39:12 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9547bec4f1bd1072083163a4a106ab5ffea62c1
Cr-Commit-Position: refs/heads/master@{#335958}

Powered by Google App Engine
This is Rietveld 408576698