Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: src/objects.cc

Issue 1210523002: Make sure bound functions never make it into optimized code map. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/runtime/runtime-function.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <iomanip> 5 #include <iomanip>
6 #include <sstream> 6 #include <sstream>
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #include "src/accessors.h" 10 #include "src/accessors.h"
(...skipping 9605 matching lines...) Expand 10 before | Expand all | Expand 10 after
9616 DCHECK(new_code_map->get(i + kOsrAstIdOffset)->IsSmi()); 9616 DCHECK(new_code_map->get(i + kOsrAstIdOffset)->IsSmi());
9617 } 9617 }
9618 #endif 9618 #endif
9619 shared->set_optimized_code_map(*new_code_map); 9619 shared->set_optimized_code_map(*new_code_map);
9620 } 9620 }
9621 9621
9622 9622
9623 FixedArray* SharedFunctionInfo::GetLiteralsFromOptimizedCodeMap(int index) { 9623 FixedArray* SharedFunctionInfo::GetLiteralsFromOptimizedCodeMap(int index) {
9624 DCHECK(index > kEntriesStart); 9624 DCHECK(index > kEntriesStart);
9625 FixedArray* code_map = FixedArray::cast(optimized_code_map()); 9625 FixedArray* code_map = FixedArray::cast(optimized_code_map());
9626 if (!bound()) { 9626 FixedArray* cached_literals = FixedArray::cast(code_map->get(index + 1));
9627 FixedArray* cached_literals = FixedArray::cast(code_map->get(index + 1)); 9627 DCHECK_NOT_NULL(cached_literals);
9628 DCHECK_NOT_NULL(cached_literals); 9628 return cached_literals;
9629 return cached_literals;
9630 }
9631 return NULL;
9632 } 9629 }
9633 9630
9634 9631
9635 Code* SharedFunctionInfo::GetCodeFromOptimizedCodeMap(int index) { 9632 Code* SharedFunctionInfo::GetCodeFromOptimizedCodeMap(int index) {
9636 DCHECK(index > kEntriesStart); 9633 DCHECK(index > kEntriesStart);
9637 FixedArray* code_map = FixedArray::cast(optimized_code_map()); 9634 FixedArray* code_map = FixedArray::cast(optimized_code_map());
9638 Code* code = Code::cast(code_map->get(index)); 9635 Code* code = Code::cast(code_map->get(index));
9639 DCHECK_NOT_NULL(code); 9636 DCHECK_NOT_NULL(code);
9640 return code; 9637 return code;
9641 } 9638 }
(...skipping 6596 matching lines...) Expand 10 before | Expand all | Expand 10 after
16238 Handle<Object> new_value) { 16235 Handle<Object> new_value) {
16239 if (cell->value() != *new_value) { 16236 if (cell->value() != *new_value) {
16240 cell->set_value(*new_value); 16237 cell->set_value(*new_value);
16241 Isolate* isolate = cell->GetIsolate(); 16238 Isolate* isolate = cell->GetIsolate();
16242 cell->dependent_code()->DeoptimizeDependentCodeGroup( 16239 cell->dependent_code()->DeoptimizeDependentCodeGroup(
16243 isolate, DependentCode::kPropertyCellChangedGroup); 16240 isolate, DependentCode::kPropertyCellChangedGroup);
16244 } 16241 }
16245 } 16242 }
16246 } // namespace internal 16243 } // namespace internal
16247 } // namespace v8 16244 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/runtime/runtime-function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698