Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Side by Side Diff: extensions/renderer/script_context_set_unittest.cc

Issue 1210513002: ScriptContextSetTest should close the main frame before finishing the test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/scoped_web_frame.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "extensions/common/extension.h" 8 #include "extensions/common/extension.h"
9 #include "extensions/common/extension_set.h" 9 #include "extensions/common/extension_set.h"
10 #include "extensions/common/features/feature.h" 10 #include "extensions/common/features/feature.h"
11 #include "extensions/renderer/scoped_web_frame.h"
11 #include "extensions/renderer/script_context.h" 12 #include "extensions/renderer/script_context.h"
12 #include "extensions/renderer/script_context_set.h" 13 #include "extensions/renderer/script_context_set.h"
13 #include "gin/public/context_holder.h" 14 #include "gin/public/context_holder.h"
14 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
15 #include "third_party/WebKit/public/web/WebLocalFrame.h" 16 #include "third_party/WebKit/public/web/WebFrame.h"
16 #include "third_party/WebKit/public/web/WebView.h"
17 #include "v8/include/v8.h" 17 #include "v8/include/v8.h"
18 18
19 namespace extensions { 19 namespace extensions {
20 20
21 TEST(ScriptContextSetTest, Lifecycle) { 21 TEST(ScriptContextSetTest, Lifecycle) {
22 base::MessageLoop loop; 22 base::MessageLoop loop;
23 23 ScopedWebFrame web_frame;
24 blink::WebView* webview = blink::WebView::create(nullptr);
25 blink::WebLocalFrame* frame =
26 blink::WebLocalFrame::create(blink::WebTreeScopeType::Document, nullptr);
27 webview->setMainFrame(frame);
28 24
29 // Do this after construction of the webview, since it may construct the 25 // Do this after construction of the webview, since it may construct the
30 // Isolate. 26 // Isolate.
31 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 27 v8::Isolate* isolate = v8::Isolate::GetCurrent();
32 28
33 v8::HandleScope handle_scope(isolate); 29 v8::HandleScope handle_scope(isolate);
34 v8::Local<v8::Context> v8_context = v8::Context::New(isolate); 30 v8::Local<v8::Context> v8_context = v8::Context::New(isolate);
35 v8::Context::Scope context_scope(v8_context); 31 v8::Context::Scope context_scope(v8_context);
36 // ScriptContext relies on gin, it just doesn't look like it from here. 32 // ScriptContext relies on gin, it just doesn't look like it from here.
37 gin::ContextHolder context_holder(isolate); 33 gin::ContextHolder context_holder(isolate);
38 context_holder.SetContext(v8_context); 34 context_holder.SetContext(v8_context);
39 35
40 ExtensionSet extensions; 36 ExtensionSet extensions;
41 ExtensionIdSet active_extensions; 37 ExtensionIdSet active_extensions;
42 ScriptContextSet context_set(&extensions, &active_extensions); 38 ScriptContextSet context_set(&extensions, &active_extensions);
43 ScriptContext* context = context_set.Register( 39 ScriptContext* context = context_set.Register(
44 frame, v8_context, 0, 0); // no extension group or world ID 40 web_frame.frame(), v8_context, 0, 0); // no extension group or world ID
45 41
46 // Context is valid and resembles correctness. 42 // Context is valid and resembles correctness.
47 EXPECT_TRUE(context->is_valid()); 43 EXPECT_TRUE(context->is_valid());
48 EXPECT_EQ(frame, context->web_frame()); 44 EXPECT_EQ(web_frame.frame(), context->web_frame());
49 EXPECT_EQ(v8_context, context->v8_context()); 45 EXPECT_EQ(v8_context, context->v8_context());
50 46
51 // Context has been correctly added. 47 // Context has been correctly added.
52 EXPECT_EQ(1u, context_set.size()); 48 EXPECT_EQ(1u, context_set.size());
53 EXPECT_EQ(context, context_set.GetByV8Context(v8_context)); 49 EXPECT_EQ(context, context_set.GetByV8Context(v8_context));
54 50
55 // Test context is correctly removed. 51 // Test context is correctly removed.
56 context_set.Remove(context); 52 context_set.Remove(context);
57 EXPECT_EQ(0u, context_set.size()); 53 EXPECT_EQ(0u, context_set.size());
58 EXPECT_EQ(nullptr, context_set.GetByV8Context(v8_context)); 54 EXPECT_EQ(nullptr, context_set.GetByV8Context(v8_context));
59 55
60 // After removal, the context should be marked for destruction. 56 // After removal, the context should be marked for destruction.
61 EXPECT_FALSE(context->is_valid()); 57 EXPECT_FALSE(context->is_valid());
62 58
63 // Run loop to do the actual deletion. 59 // Run loop to do the actual deletion.
64 loop.RunUntilIdle(); 60 loop.RunUntilIdle();
65 } 61 }
66 62
67 } // namespace extensions 63 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/scoped_web_frame.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698