Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1210463002: X87: Use big-boy Types to annotate interface descriptor parameters. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use big-boy Types to annotate interface descriptor parameters. port c019d7f498ce6fbac6659924e20ddb6c59aebeb8 (r29248). original commit message: Use big-boy Types to annotate interface descriptor parameters - Thread Type::FunctionType through stubs and the TF pipeline. - Augment Typer to decorate parameter nodes with types from a Type::FunctionType associated with interface descriptors. - Factor interface descriptors into platform-specific and platform-independent components so that all descriptors share a common Type::FunctionType for all platforms. BUG= Committed: https://crrev.com/aaa92726f0ee079dcdcfd9b340a424b60610121a Cr-Commit-Position: refs/heads/master@{#29406}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -128 lines) Patch
M src/x87/interface-descriptors-x87.cc View 4 chunks +90 lines, -128 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 5 months ago (2015-06-30 09:16:12 UTC) #2
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 11:01:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210463002/1
5 years, 5 months ago (2015-07-01 11:01:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-01 11:27:58 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 11:28:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaa92726f0ee079dcdcfd9b340a424b60610121a
Cr-Commit-Position: refs/heads/master@{#29406}

Powered by Google App Engine
This is Rietveld 408576698