Issue 12104003: Updated GCM for Chrome docs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12104003: Updated GCM for Chrome docs (Closed)

Created:
7 years, 10 months ago by mkearney1

Modified:
7 years, 10 months ago

Reviewers:
markdavidscott, Pete Williamson, afeldman, jhartman

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Updated GCM for Chrome docs This is based on feedback from Adam Feldman and Jed Hartman. Adam requested that Terms of Service be formatted as the norm for Google APIs. Jed gave lots of excellent feedback to make the docs look and read better. I've actioned all the feedback with the exception of improvments Jed suggested to make to the generated API client reference. Since this stuff is generated across all the docs, instead of making big css changes globally, I've added his review comments to the list of changes that we want to make to across the docs UI. The API reference is getting a clean-up, so seems like the right time to make these changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180148

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -42 lines)			Patch
M	chrome/common/extensions/docs/templates/articles/cloudMessaging.html	View	1	20 chunks	+37 lines, -37 lines	0 comments	Download
M	chrome/common/extensions/docs/templates/articles/gcm_server.html	View		5 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/docs/templates/articles/gcm_tos.html	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Pete Williamson

7 years, 10 months ago (2013-02-01 01:18:01 UTC) #1

LGTM after you fix a few nits.

https://codereview.chromium.org/12104003/diff/1/chrome/common/extensions/docs...
File chrome/common/extensions/docs/templates/articles/cloudMessaging.html
(right):

https://codereview.chromium.org/12104003/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/templates/articles/cloudMessaging.html:83: The
most recent message sent on each subchannel are automatically queued
are -> is

https://codereview.chromium.org/12104003/diff/1/chrome/common/extensions/docs...
chrome/common/extensions/docs/templates/articles/cloudMessaging.html:117: for
any user who is to receive a message.</li>
nit - are tabs allowed here?

Expand Messages | Collapse Messages