Issue 1210373002: Oilpan: Decrease m_promptlyFreedSize in makeConsistentForMutator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1210373002: Oilpan: Decrease m_promptlyFreedSize in makeConsistentForMutator (Closed)

Created:
4 years, 10 months ago by haraken

Modified:
4 years, 10 months ago

Reviewers:
keishi, Primiano Tucci (use gerrit), ssid

CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: Decrease m_promptlyFreedSize in makeConsistentForMutator This CL fixes crashes when running a snapshot GC. Currently the increase/decrease balance of m_promptlyFreedSize is broken, and we hit ASSERT(m_promptlyFreedSize == freedSize) at line 731. BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197894

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	Source/platform/heap/Heap.cpp	View		2 chunks	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210373002/1

4 years, 10 months ago (2015-06-26 05:18:08 UTC) #6

commit-bot: I haz the power

4 years, 10 months ago (2015-06-26 06:27:07 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197894

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages