Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1210333002: Make CPU profile models public and refactor model building code (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make CPU profile models public and refactor model building code - Most of the refactoring is just organization. - The core data structures and algorithms are not changed in this CL. - I tried to use the same code wherever I could (renaming aside). R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ac2a1ccc62f64a1bb80bf0c072379ac65a5c8911

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1645 lines, -1758 lines) Patch
M runtime/vm/profiler_service.h View 1 2 chunks +299 lines, -4 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 18 chunks +1338 lines, -1746 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-26 02:38:42 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/1210333002/diff/1/runtime/vm/profiler_service.cc File runtime/vm/profiler_service.cc (right): https://chromiumcodereview.appspot.com/1210333002/diff/1/runtime/vm/profiler_service.cc#newcode20 runtime/vm/profiler_service.cc:20: DEFINE_FLAG(bool, trace_profiler, true, "Trace profiler."); Disable before landing ...
5 years, 6 months ago (2015-06-26 17:37:44 UTC) #3
Cutch
https://chromiumcodereview.appspot.com/1210333002/diff/1/runtime/vm/profiler_service.cc File runtime/vm/profiler_service.cc (right): https://chromiumcodereview.appspot.com/1210333002/diff/1/runtime/vm/profiler_service.cc#newcode20 runtime/vm/profiler_service.cc:20: DEFINE_FLAG(bool, trace_profiler, true, "Trace profiler."); On 2015/06/26 17:37:44, rmacnak ...
5 years, 6 months ago (2015-06-26 17:48:41 UTC) #4
Cutch
5 years, 6 months ago (2015-06-26 17:49:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ac2a1ccc62f64a1bb80bf0c072379ac65a5c8911 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698