content/public/common/push_messaging_status.cc - Issue 1210283005: Introduce the PushSubscription.curve25519dh attribute (2/3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/push_messaging_status.cc

Issue 1210283005: Introduce the PushSubscription.curve25519dh attribute (2/3) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/push_messaging_messages.h ('K') | « content/public/common/push_messaging_status.h ('k') | content/renderer/push_messaging/push_messaging_dispatcher.h » ('j') | content/shell/browser/layout_test/layout_test_push_messaging_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/push_messaging_status.cc

diff --git a/content/public/common/push_messaging_status.cc b/content/public/common/push_messaging_status.cc

index 9b4a42138e6acadee9eba552ca704292818010d2..a0aa99eaa4668fbeb21db4fc4d5b09049b2f7dee 100644

--- a/content/public/common/push_messaging_status.cc

+++ b/content/public/common/push_messaging_status.cc

@@ -44,6 +44,9 @@ const char* PushRegistrationStatusToString(PushRegistrationStatus status) {

// We split this out for UMA, but it must be indistinguishable to JS.

return PushRegistrationStatusToString(

PUSH_REGISTRATION_STATUS_PERMISSION_DENIED);

+ case PUSH_REGISTRATION_STATUS_PUBLIC_KEY_UNAVAILABLE:

+ return "Registration failed - could not retrieve the public key";

}

NOTREACHED();

return "";