Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 1210283003: Extend allocation profile testing (Closed) Base URL: git@github.com:dart-lang/sdk.git@profile_model_public
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_ia32.cc
diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc
index e6f881841c5525a92c5cab00332077337d5cb1f7..95ba1116eda3a0bf588835728e69124790a01aca 100644
--- a/runtime/vm/stub_code_ia32.cc
+++ b/runtime/vm/stub_code_ia32.cc
@@ -1055,7 +1055,8 @@ void StubCode::GenerateAllocationStubForClass(
__ movl(EDX, Address(ESP, kObjectTypeArgumentsOffset));
// EDX: instantiated type arguments.
}
- if (FLAG_inline_alloc && Heap::IsAllocatableInNewSpace(instance_size)) {
+ if (FLAG_inline_alloc && Heap::IsAllocatableInNewSpace(instance_size) &&
srdjan 2015/06/26 18:18:22 You may want to run all tests with --vm-options=--
Cutch 2015/06/26 19:21:41 $ ./tools/test.py --vm-options=--no-inline-alloc [
+ !cls.trace_allocation()) {
Label slow_case;
// Allocate the object and update top to point to
// next object start and initialize the allocated object.

Powered by Google App Engine
This is Rietveld 408576698