Source/core/input/EventHandler.cpp - Issue 1210253003: Fix wheel event dispatch logic to fallback to document when hit-test fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/input/EventHandler.cpp

Issue 1210253003: Fix wheel event dispatch logic to fallback to document when hit-test fails (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address nits Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/dispatch-mouse-events-to-window-always-expected.txt ('k') | Source/core/paint/DeprecatedPaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/input/EventHandler.cpp

diff --git a/Source/core/input/EventHandler.cpp b/Source/core/input/EventHandler.cpp

index 19698b6bf5a0b587896378adc6a5058273c8515d..0f9dd0cf3ff0750fadb0c22a50f7edc318535ea2 100644

--- a/Source/core/input/EventHandler.cpp

+++ b/Source/core/input/EventHandler.cpp

@@ -1725,7 +1725,9 @@ bool EventHandler::handleWheelEvent(const PlatformWheelEvent& event)

LayoutPoint vPoint = view->rootFrameToContents(event.position());

- HitTestRequest request(HitTestRequest::ReadOnly);

+ // Pass Active to ensure that hit-test result in current document if otherwise empty

+ // TODO(majidvp): Avoid using Active to trigger hit-testing fallback. See http://crbug.com/505825

+ HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::Active);

HitTestResult result(request, vPoint);

doc->layoutView()->hitTest(result);