Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1210253003: Fix wheel event dispatch logic to fallback to document when hit-test fails (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Replace with passing Active to be consistent Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/input/EventHandler.cpp ('K') | « Source/core/input/EventHandler.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/DeprecatedPaintLayer.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayer.cpp b/Source/core/paint/DeprecatedPaintLayer.cpp
index ab65b911838ce0184d324bcf406f3da45531eeb7..9c8eaa20c93c911771e086be04d5e8883fbe089d 100644
--- a/Source/core/paint/DeprecatedPaintLayer.cpp
+++ b/Source/core/paint/DeprecatedPaintLayer.cpp
@@ -1603,6 +1603,8 @@ bool DeprecatedPaintLayer::hitTest(const HitTestRequest& request, const HitTestL
// exited the WebView, and so hit testing over a scrollbar hits the content document.
// In addtion, it is possible for the mouse to stay in the document but there is no element.
// At that time, the events of the mouse should be fired.
+ // TODO(majidvp): This should apply more consistently across different event types and we should not use
Rick Byers 2015/06/30 20:14:49 nit: follow the wrapping of the rest of the commen
majidvp 2015/06/30 22:48:32 Done.
+ // RequestType for it. Perhaps best for it to be done at a higher level. See http://crbug.com/505825
LayoutPoint hitPoint = hitTestLocation.point();
if (!request.isChildFrameHitTest() && ((request.active() || request.release()) || (request.move() && hitTestArea.contains(hitPoint.x(), hitPoint.y()))) && isRootLayer()) {
layoutObject()->updateHitTestResult(result, toLayoutView(layoutObject())->flipForWritingMode(hitTestLocation.point()));
« Source/core/input/EventHandler.cpp ('K') | « Source/core/input/EventHandler.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698