Issue 121023002: Remove GYP_GENERATORS=ninja code from android envsetup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 121023002: Remove GYP_GENERATORS=ninja code from android envsetup. (Closed)

Created:
6 years, 12 months ago by Nico

Modified:
6 years, 11 months ago

Reviewers:
Daniel Erat, Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove GYP_GENERATORS=ninja code from android envsetup. build/gyp_chromium already makes GYP_GENERATORS default to ninja on linux these days. BUG=330631 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242576

Patch Set 1 #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -10 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/121023002/1

6 years, 12 months ago (2013-12-26 18:15:42 UTC) #3

Torne

6 years, 11 months ago (2014-01-02 11:26:35 UTC) #5

Message was sent while issue was closed.

On 2013/12/27 00:00:28, I haz the power (commit-bot) wrote:
> Change committed as 242576

LGTM, thanks

Expand Messages | Collapse Messages