Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.h

Issue 1210173012: Split the Media settings UI into separate microphone and camera sections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the policy indicator test. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/content_settings_handler.h
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.h b/chrome/browser/ui/webui/options/content_settings_handler.h
index 7ae81cb30b015f6d407d9b049f40a9468a8bc0fa..c6b5e22eabfc7d8ae0feb9998d152cff5e07938f 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.h
+++ b/chrome/browser/ui/webui/options/content_settings_handler.h
@@ -98,8 +98,9 @@ class ContentSettingsHandler : public OptionsPageUIHandler,
// Updates the page with the default settings (allow, ask, block, etc.)
void UpdateSettingDefaultFromModel(ContentSettingsType type);
- // Updates the media radio buttons according to the enabled split prefs.
- void UpdateMediaSettingsView();
+ // Compares the media default settings with flash and updates the flash links
raymes 2015/07/17 00:39:40 nit: links -> link's
msramek 2015/07/17 11:59:50 Actually, there are now two of them (one for mic,
Bernhard Bauer 2015/07/17 13:29:01 links' then :) (Or just "visibility of the links"
msramek 2015/07/17 14:01:24 Yep, I already have "links'" :)
+ // visibility accordingly.
+ void CompareMediaSettingsWithFlash();
// Clobbers and rebuilds the specific content setting type exceptions table.
void UpdateExceptionsViewFromModel(ContentSettingsType type);
@@ -121,8 +122,9 @@ class ContentSettingsHandler : public OptionsPageUIHandler,
// Clobbers and rebuilds just the desktop notification exception table.
void UpdateNotificationExceptionsView();
- // Clobbers and rebuilds just the Media device exception table.
- void UpdateMediaExceptionsView();
+ // Compares the combined microphone and camera exceptions with Flash
+ // exceptions and updates the flash links visibility accordingly.
raymes 2015/07/17 00:39:40 link -> link's
msramek 2015/07/17 11:59:50 Ditto.
+ void CompareMediaExceptionsWithFlash();
// Clobbers and rebuilds just the MIDI SysEx exception table.
void UpdateMIDISysExExceptionsView();
@@ -155,10 +157,6 @@ class ContentSettingsHandler : public OptionsPageUIHandler,
// to RemoveException().
void RemoveNotificationException(const base::ListValue* args);
- // Removes one media camera and microphone exception. |args| contains the
- // parameters passed to RemoveException().
- void RemoveMediaException(const base::ListValue* args);
-
// Removes one exception of |type| from the host content settings map. |args|
// contains the parameters passed to RemoveException().
void RemoveExceptionFromHostContentSettingsMap(

Powered by Google App Engine
This is Rietveld 408576698