Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1210173011: Enforce that BluetoothUUID.canonicalUUID() takes approximately an in-range integer. (Closed)

Created:
5 years, 5 months ago by Jeffrey Yasskin
Modified:
5 years, 5 months ago
Reviewers:
scheib, ortuno
CC:
blink-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@pinned
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enforce that BluetoothUUID.canonicalUUID() takes approximately an in-range integer. This was added to the spec in https://github.com/WebBluetoothCG/web-bluetooth/issues/133. BUG=491441 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M LayoutTests/bluetooth/idl-BluetoothUUID.html View 1 chunk +6 lines, -4 lines 0 comments Download
M Source/modules/bluetooth/BluetoothUUID.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Jeffrey Yasskin
The behavior here is slightly odd. I've filed https://www.w3.org/Bugs/Public/show_bug.cgi?id=28875 to fix it, but that may ...
5 years, 5 months ago (2015-07-01 21:25:03 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210173011/1
5 years, 5 months ago (2015-07-01 21:25:29 UTC) #4
scheib
Some coverage is better than none. So I vote we take this. Spec for canonicalUUID ...
5 years, 5 months ago (2015-07-01 21:45:34 UTC) #5
scheib
Hey look, the spec now includes this change. So LGTM.
5 years, 5 months ago (2015-07-01 22:43:30 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-01 22:50:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210173011/1
5 years, 5 months ago (2015-07-01 23:09:09 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 23:12:53 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198172

Powered by Google App Engine
This is Rietveld 408576698