Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1210153007: X87: Clean up JSConstructStub. (Closed)

Created:
5 years, 5 months ago by chunyang.dai
Modified:
5 years, 5 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Clean up JSConstructStub. port 882055ff6a58f6b585575229f40f364e5f2a3ad0 (r29082). The original CL covers part of X87 port. This CL addes the missing changes. original commit message: - fix truthfulness of comments - use InitializeFieldsWithFiller more consistently - use unsigned comparisons for pointers No change in functionality intended. Bonus: improve JavaScriptFrame::Print() for an enhanced debugging experience: BUG= Committed: https://crrev.com/32f32bdf12b3c856a6f4999599b359ac2203e208 Cr-Commit-Position: refs/heads/master@{#29397}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +3 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL
5 years, 5 months ago (2015-06-30 09:13:05 UTC) #3
Weiliang
lgtm
5 years, 5 months ago (2015-07-01 01:24:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210153007/20001
5 years, 5 months ago (2015-07-01 01:24:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 5 months ago (2015-07-01 01:52:07 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 01:52:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/32f32bdf12b3c856a6f4999599b359ac2203e208
Cr-Commit-Position: refs/heads/master@{#29397}

Powered by Google App Engine
This is Rietveld 408576698