Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1210153003: Fix flag convention in handle count tests and comment. (Closed)

Created:
5 years, 5 months ago by oth
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix flag convention in handle count tests and comment. BUG=505228 LOG=Y Committed: https://crrev.com/2b87cf56b4666df976dcde1bf7550843ed77021e Cr-Commit-Position: refs/heads/master@{#29346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/handles.h View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/handle-count-ast.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/handle-count-runtime-literals.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
oth
ishell,mstarzinger PTAL.
5 years, 5 months ago (2015-06-29 11:28:35 UTC) #2
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-06-29 11:29:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210153003/1
5 years, 5 months ago (2015-06-29 12:26:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/3803)
5 years, 5 months ago (2015-06-29 12:29:19 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210153003/1
5 years, 5 months ago (2015-06-29 12:44:27 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-29 13:37:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1210153003/1
5 years, 5 months ago (2015-06-29 13:39:13 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-06-29 13:40:46 UTC) #14
commit-bot: I haz the power
5 years, 5 months ago (2015-06-29 13:40:59 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2b87cf56b4666df976dcde1bf7550843ed77021e
Cr-Commit-Position: refs/heads/master@{#29346}

Powered by Google App Engine
This is Rietveld 408576698